summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThiago Marcos P. Santos <tmpsantos@gmail.com>2019-12-12 16:44:41 +0200
committerThiago Marcos P. Santos <tmpsantos@gmail.com>2019-12-12 17:44:11 +0200
commit3bbea2e30c2a7942d16586c5dea770cccfba5ae0 (patch)
treefbd294d00afd3d773cab55c2f10379f29f03a6d7
parent79768743d8d9f61303d653a515ed1d218b6e54f4 (diff)
downloadqtlocation-mapboxgl-3bbea2e30c2a7942d16586c5dea770cccfba5ae0.tar.gz
[core] Fix -Wshadow when using GCC 4.9
-rw-r--r--src/mbgl/style/collection.hpp8
-rw-r--r--src/mbgl/style/sources/geojson_source.cpp6
2 files changed, 7 insertions, 7 deletions
diff --git a/src/mbgl/style/collection.hpp b/src/mbgl/style/collection.hpp
index 91244cb711..7d67fac94f 100644
--- a/src/mbgl/style/collection.hpp
+++ b/src/mbgl/style/collection.hpp
@@ -63,12 +63,12 @@ class Collection<T, false /*persistentImplsOrder*/> : public CollectionBase<T> {
public:
T* add(std::unique_ptr<T> wrapper, const optional<std::string>& before = nullopt) {
- std::size_t index = before ? Base::index(*before) : Base::size();
- return Base::add(index, index, std::move(wrapper));
+ std::size_t idx = before ? Base::index(*before) : Base::size();
+ return Base::add(idx, idx, std::move(wrapper));
}
std::unique_ptr<T> remove(const std::string& id) {
- std::size_t index = Base::index(id);
- return Base::remove(index, index);
+ std::size_t idx = Base::index(id);
+ return Base::remove(idx, idx);
}
void update(const T& wrapper) { Base::update(Base::index(wrapper.getID()), wrapper); }
};
diff --git a/src/mbgl/style/sources/geojson_source.cpp b/src/mbgl/style/sources/geojson_source.cpp
index ea6fb5cc68..7767859b38 100644
--- a/src/mbgl/style/sources/geojson_source.cpp
+++ b/src/mbgl/style/sources/geojson_source.cpp
@@ -78,16 +78,16 @@ void GeoJSONSource::loadDescription(FileSource& fileSource) {
} else {
auto makeImplInBackground = [currentImpl = baseImpl, data = res.data]() -> Immutable<Source::Impl> {
assert(data);
- auto& impl = static_cast<const Impl&>(*currentImpl);
+ auto& current = static_cast<const Impl&>(*currentImpl);
conversion::Error error;
std::shared_ptr<GeoJSONData> geoJSONData;
if (optional<GeoJSON> geoJSON = conversion::convertJSON<GeoJSON>(*data, error)) {
- geoJSONData = GeoJSONData::create(*geoJSON, impl.getOptions());
+ geoJSONData = GeoJSONData::create(*geoJSON, current.getOptions());
} else {
// Create an empty GeoJSON VT object to make sure we're not infinitely waiting for tiles to load.
Log::Error(Event::ParseStyle, "Failed to parse GeoJSON data: %s", error.message.c_str());
}
- return makeMutable<Impl>(impl, std::move(geoJSONData));
+ return makeMutable<Impl>(current, std::move(geoJSONData));
};
auto onImplReady = [this, self = makeWeakPtr(), capturedReq = req.get()](Immutable<Source::Impl> newImpl) {
assert(capturedReq);