diff options
author | Fabian Guerra <fabian.guerra@mapbox.com> | 2019-09-19 10:28:33 -0700 |
---|---|---|
committer | Fabian Guerra <fabian.guerra@mapbox.com> | 2019-10-07 15:39:35 -0700 |
commit | 5ac1c787f289899b559f4dc1ba872fbe44560b95 (patch) | |
tree | fc2a0190fc033efecdf018bd3ee27b151d84c30c | |
parent | d1846859e7e8b296547d8e93ee6987b7def63b21 (diff) | |
download | qtlocation-mapboxgl-5ac1c787f289899b559f4dc1ba872fbe44560b95.tar.gz |
[ios] Use NetworkStatus::Status for stopping network requests.
-rw-r--r-- | platform/darwin/filesource-files.json | 2 | ||||
-rw-r--r-- | platform/darwin/src/MGLNetworkConfiguration.mm (renamed from platform/darwin/src/MGLNetworkConfiguration.m) | 18 | ||||
-rw-r--r-- | platform/darwin/src/http_file_source.mm | 4 | ||||
-rw-r--r-- | platform/ios/ios.xcodeproj/project.pbxproj | 12 |
4 files changed, 25 insertions, 11 deletions
diff --git a/platform/darwin/filesource-files.json b/platform/darwin/filesource-files.json index 62043a0dcd..6600f9691d 100644 --- a/platform/darwin/filesource-files.json +++ b/platform/darwin/filesource-files.json @@ -2,7 +2,7 @@ "//": "This file can be edited manually and is the canonical source.", "sources": [ "platform/darwin/src/MGLLoggingConfiguration.mm", - "platform/darwin/src/MGLNetworkConfiguration.m", + "platform/darwin/src/MGLNetworkConfiguration.mm", "platform/darwin/src/http_file_source.mm", "platform/default/src/mbgl/storage/file_source.cpp", "platform/default/src/mbgl/storage/sqlite3.cpp" diff --git a/platform/darwin/src/MGLNetworkConfiguration.m b/platform/darwin/src/MGLNetworkConfiguration.mm index 0e5046e7a3..fba78e4e81 100644 --- a/platform/darwin/src/MGLNetworkConfiguration.m +++ b/platform/darwin/src/MGLNetworkConfiguration.mm @@ -1,6 +1,7 @@ #import "MGLNetworkConfiguration_Private.h" #include <mbgl/storage/reachability.h> +#include <mbgl/storage/network_status.hpp> static NSString * const MGLStartTime = @"start_time"; static NSString * const MGLResourceType = @"resource_type"; @@ -66,6 +67,23 @@ NSString * const kMGLDownloadPerformanceEvent = @"mobile.performance_trace"; return sessionConfiguration; } +- (void)setStopsRequests:(BOOL)stopsRequests { + if (stopsRequests) { + mbgl::NetworkStatus::Set(mbgl::NetworkStatus::Status::Offline); + } else { + mbgl::NetworkStatus::Set(mbgl::NetworkStatus::Status::Online); + } +} + +- (BOOL)stopsRequests { + auto status = mbgl::NetworkStatus::Get(); + if (status == mbgl::NetworkStatus::Status::Offline) { + return YES; + } else { + return NO; + } +} + - (void)startDownloadEvent:(NSString *)urlString type:(NSString *)resourceType { if (urlString && ![self eventDictionaryForKey:urlString]) { NSDate *startDate = [NSDate date]; diff --git a/platform/darwin/src/http_file_source.mm b/platform/darwin/src/http_file_source.mm index 09562e0347..b0f69f4a7f 100644 --- a/platform/darwin/src/http_file_source.mm +++ b/platform/darwin/src/http_file_source.mm @@ -229,10 +229,6 @@ NSURL *resourceURLWithAccountType(const Resource& resource, NSInteger accountTyp std::unique_ptr<AsyncRequest> HTTPFileSource::request(const Resource& resource, Callback callback) { auto request = std::make_unique<HTTPRequest>(callback); auto shared = request->shared; // Explicit copy so that it also gets copied into the completion handler block below. - - if ([MGLNetworkConfiguration sharedManager].stopsRequests) { - return std::move(request); - } @autoreleasepool { NSURL *url = resourceURLWithAccountType(resource, impl->accountType); diff --git a/platform/ios/ios.xcodeproj/project.pbxproj b/platform/ios/ios.xcodeproj/project.pbxproj index 350a8014fd..a5a7785e7d 100644 --- a/platform/ios/ios.xcodeproj/project.pbxproj +++ b/platform/ios/ios.xcodeproj/project.pbxproj @@ -762,8 +762,8 @@ DAF2571B201901E200367EF5 /* MGLHillshadeStyleLayer.h in Headers */ = {isa = PBXBuildFile; fileRef = DAF25718201901E200367EF5 /* MGLHillshadeStyleLayer.h */; settings = {ATTRIBUTES = (Public, ); }; }; DAF2571C201901E200367EF5 /* MGLHillshadeStyleLayer.h in Headers */ = {isa = PBXBuildFile; fileRef = DAF25718201901E200367EF5 /* MGLHillshadeStyleLayer.h */; settings = {ATTRIBUTES = (Public, ); }; }; DAF25720201902BC00367EF5 /* MGLHillshadeStyleLayerTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = DAF2571F201902BB00367EF5 /* MGLHillshadeStyleLayerTests.mm */; }; - DD0902A91DB1929D00C5BDCE /* MGLNetworkConfiguration.m in Sources */ = {isa = PBXBuildFile; fileRef = DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.m */; }; - DD0902AA1DB1929D00C5BDCE /* MGLNetworkConfiguration.m in Sources */ = {isa = PBXBuildFile; fileRef = DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.m */; }; + DD0902A91DB1929D00C5BDCE /* MGLNetworkConfiguration.mm in Sources */ = {isa = PBXBuildFile; fileRef = DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.mm */; }; + DD0902AA1DB1929D00C5BDCE /* MGLNetworkConfiguration.mm in Sources */ = {isa = PBXBuildFile; fileRef = DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.mm */; }; DD0902AB1DB192A800C5BDCE /* MGLNetworkConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = DD0902A41DB18F1B00C5BDCE /* MGLNetworkConfiguration.h */; settings = {ATTRIBUTES = (Public, ); }; }; DD4823751D94AE6C00EB71B7 /* fill_filter_style.json in Resources */ = {isa = PBXBuildFile; fileRef = DD4823721D94AE6C00EB71B7 /* fill_filter_style.json */; }; DD4823761D94AE6C00EB71B7 /* line_filter_style.json in Resources */ = {isa = PBXBuildFile; fileRef = DD4823731D94AE6C00EB71B7 /* line_filter_style.json */; }; @@ -1470,7 +1470,7 @@ DAFEB3762093AE6800A86A83 /* ko */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = ko; path = ko.lproj/Foundation.stringsdict; sourceTree = "<group>"; }; DAFEB3772093AE7900A86A83 /* ko */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ko; path = ko.lproj/Localizable.strings; sourceTree = "<group>"; }; DAFEB3782093AE9200A86A83 /* ko */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = ko; path = ko.lproj/Localizable.stringsdict; sourceTree = "<group>"; }; - DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MGLNetworkConfiguration.m; sourceTree = "<group>"; }; + DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = MGLNetworkConfiguration.mm; sourceTree = "<group>"; }; DD0902A41DB18F1B00C5BDCE /* MGLNetworkConfiguration.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MGLNetworkConfiguration.h; sourceTree = "<group>"; }; DD4823721D94AE6C00EB71B7 /* fill_filter_style.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = fill_filter_style.json; sourceTree = "<group>"; }; DD4823731D94AE6C00EB71B7 /* line_filter_style.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = line_filter_style.json; sourceTree = "<group>"; }; @@ -2164,7 +2164,7 @@ 927FBCFE1F4DB05500F8BF1F /* MGLMapSnapshotter.mm */, DD0902A41DB18F1B00C5BDCE /* MGLNetworkConfiguration.h */, 1F2B94BF221636D800210640 /* MGLNetworkConfiguration_Private.h */, - DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.m */, + DD0902A21DB18DE700C5BDCE /* MGLNetworkConfiguration.mm */, 3EA9337830C7738BF7F5493C /* MGLRendererConfiguration.h */, 3EA931BC4F087E166D538F21 /* MGLRendererConfiguration.mm */, 92F2C3EC1F0E3C3A00268EC0 /* MGLRendererFrontend.h */, @@ -3418,7 +3418,7 @@ 40834BF01FE05E1800C1BD0D /* MMELocationManager.m in Sources */, DA8848281CBAFA6200AB86E3 /* MGLShape.mm in Sources */, DA35A2B31CCA141D00E826B2 /* MGLCompassDirectionFormatter.m in Sources */, - DD0902A91DB1929D00C5BDCE /* MGLNetworkConfiguration.m in Sources */, + DD0902A91DB1929D00C5BDCE /* MGLNetworkConfiguration.mm in Sources */, 35D13AB91D3D15E300AFB4E0 /* MGLStyleLayer.mm in Sources */, 74CB5EB3219B252C00102936 /* MGLStyleLayerManager.mm in Sources */, DA35A2CB1CCAAAD200E826B2 /* NSValue+MGLAdditions.m in Sources */, @@ -3539,7 +3539,7 @@ 9C6E282C22A981580056B7BE /* MGLMapboxEvents.m in Sources */, DAA4E41F1CBB730400178DFB /* MGLMultiPoint.mm in Sources */, 96E6145C22CC169000109F14 /* MGLCompassButton.mm in Sources */, - DD0902AA1DB1929D00C5BDCE /* MGLNetworkConfiguration.m in Sources */, + DD0902AA1DB1929D00C5BDCE /* MGLNetworkConfiguration.mm in Sources */, 40834C041FE05E1800C1BD0D /* MMELocationManager.m in Sources */, 9C6E281F22A980AC0056B7BE /* CLLocation+MMEMobileEvents.m in Sources */, DA35A2B41CCA141D00E826B2 /* MGLCompassDirectionFormatter.m in Sources */, |