summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnder Conselvan de Oliveira <ander.deoliveira@mapbox.com>2019-03-04 13:18:22 +0200
committerAnder Conselvan de Oliveira <ander.deoliveira@mapbox.com>2019-03-13 15:06:56 +0200
commit8afb24b539951a6b02cf9e6e41639fea1748deda (patch)
treead8aa7eeec7c73b75021d5bdbe92c29948ff1239
parent7d1911572000d1353c1c0109402431323fcd8639 (diff)
downloadqtlocation-mapboxgl-8afb24b539951a6b02cf9e6e41639fea1748deda.tar.gz
[build] A build target to check for doxygen documentation coverage
Add a cmake target that builds doxygen documentation and reports on coverage using doxy-coverage. Script was copied from: https://github.com/alobbs/doxy-coverage/commit/29a0bbf43bfecb6872cdca0e4a11733954d25196
-rw-r--r--CMakeLists.txt1
-rw-r--r--cmake/doxygen.cmake18
-rwxr-xr-xscripts/doxy-coverage.py201
3 files changed, 220 insertions, 0 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bf7cc6465e..cdd14ee10f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -38,6 +38,7 @@ include(cmake/mbgl.cmake)
include(cmake/vendor.cmake)
include(cmake/mason.cmake)
include(cmake/xcode.cmake)
+include(cmake/doxygen.cmake)
if(WITH_CXX11ABI)
set(MASON_CXXABI_SUFFIX -cxx11abi)
diff --git a/cmake/doxygen.cmake b/cmake/doxygen.cmake
new file mode 100644
index 0000000000..c7e2fab3c4
--- /dev/null
+++ b/cmake/doxygen.cmake
@@ -0,0 +1,18 @@
+find_package(Doxygen)
+if(DOXYGEN_FOUND)
+ set(DOXYGEN_PROJECT_NAME "Mapbox GL Native")
+ set(DOXYGEN_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/docs")
+ set(DOXYGEN_GENERATE_XML TRUE)
+ set(DOXYGEN_QUIET YES)
+ set(DOXYGEN_WARN_LOGFILE ${CMAKE_BINARY_DIR}/doxygen_warn.log)
+
+ doxygen_add_docs(generate_xml_doxygen
+ ${CMAKE_SOURCE_DIR}/include
+ )
+
+ add_custom_target(doxygen_coverage
+ COMMAND ${CMAKE_SOURCE_DIR}/scripts/doxy-coverage.py --noerror "${CMAKE_BINARY_DIR}/docs/xml"
+ COMMENT "Checking documentation coverage"
+ DEPENDS generate_xml_doxygen
+ )
+endif()
diff --git a/scripts/doxy-coverage.py b/scripts/doxy-coverage.py
new file mode 100755
index 0000000000..69df8b218c
--- /dev/null
+++ b/scripts/doxy-coverage.py
@@ -0,0 +1,201 @@
+#!/usr/bin/env python
+# -*- mode: python; coding: utf-8 -*-
+
+# All files in doxy-coverage are Copyright 2014 Alvaro Lopez Ortega.
+#
+# Authors:
+# * Alvaro Lopez Ortega <alvaro@gnu.org>
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+#
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following
+# disclaimer in the documentation and/or other materials provided
+# with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from __future__ import print_function
+
+__author__ = "Alvaro Lopez Ortega"
+__email__ = "alvaro@alobbs.com"
+__copyright__ = "Copyright (C) 2014 Alvaro Lopez Ortega"
+
+import os
+import sys
+import argparse
+import xml.etree.ElementTree as ET
+
+# Defaults
+ACCEPTABLE_COVERAGE = 80
+
+# Global
+ns = None
+
+def ERROR(*objs):
+ print("ERROR: ", *objs, end='\n', file=sys.stderr)
+
+def FATAL(*objs):
+ ERROR (*objs)
+ sys.exit((1,0)[ns.noerror])
+
+def parse_file(fullpath):
+ tree = ET.parse(fullpath)
+
+ sourcefile = None
+ definitions = {}
+
+ for definition in tree.findall("./compounddef//memberdef"):
+ # Should it be documented
+ if (definition.get('kind') == 'function' and
+ definition.get('static') == 'yes'):
+ continue
+
+ # Is the definition documented?
+ documented = False
+ for k in ('briefdescription', 'detaileddescription', 'inbodydescription'):
+ if definition.findall("./%s/"%(k)):
+ documented = True
+ break
+
+ # Name
+ d_def = definition.find('./definition')
+ d_nam = definition.find('./name')
+
+ if not sourcefile:
+ l = definition.find('./location')
+ if l is not None:
+ sourcefile = l.get('file')
+
+ if d_def is not None:
+ name = d_def.text
+ elif d_nam is not None:
+ name = d_nam.text
+ else:
+ name = definition.get('id')
+
+ # Aggregate
+ definitions[name] = documented
+
+ if not sourcefile:
+ sourcefile = fullpath
+
+ return (sourcefile, definitions)
+
+
+def parse(path):
+ index_fp = os.path.join (path, "index.xml")
+ if not os.path.exists (index_fp):
+ FATAL ("Documentation not present. Exiting.", index_fp)
+
+ tree = ET.parse(index_fp)
+
+ files = {}
+ for entry in tree.findall('compound'):
+ if entry.get('kind') in ('dir'):
+ continue
+
+ file_fp = os.path.join (path, "%s.xml" %(entry.get('refid')))
+ tmp = parse_file (file_fp)
+ files[tmp[0]] = tmp[1]
+
+ return files
+
+
+def report (files, exclude_dirs):
+ def get_coverage (f):
+ defs = files[f]
+ if not defs:
+ return 100
+
+ doc_yes = len([d for d in defs.values() if d])
+ doc_no = len([d for d in defs.values() if not d])
+ return (doc_yes * 100.0 / (doc_yes + doc_no))
+
+ def file_cmp (a,b):
+ return cmp(get_coverage(a), get_coverage(b))
+
+ files_sorted = files.keys()
+ files_sorted.sort(file_cmp)
+ files_sorted.reverse()
+
+ total_yes = 0
+ total_no = 0
+
+ for f in files_sorted:
+ skip = False
+ for exclude_dir in exclude_dirs:
+ if exclude_dir in f:
+ skip = True
+ break
+ if skip:
+ continue
+
+ defs = files[f]
+ if not defs:
+ continue
+
+ doc_yes = len([d for d in defs.values() if d])
+ doc_no = len([d for d in defs.values() if not d])
+ doc_per = doc_yes * 100.0 / (doc_yes + doc_no)
+
+ total_yes += doc_yes
+ total_no += doc_no
+
+ print ('%3d%% - %s - (%d of %d)'%(doc_per, f, doc_yes, (doc_yes + doc_no)))
+
+ defs_sorted = defs.keys()
+ defs_sorted.sort()
+ for d in defs_sorted:
+ if not defs[d]:
+ print ("\t", d)
+
+ total_all = total_yes + total_no
+ total_per = total_yes * 100 / total_all
+ print()
+ print("%d%% API documentation coverage" %(total_per))
+ return (ns.threshold - total_per, 0)[total_per > ns.threshold]
+
+
+def main():
+ # Arguments
+ parser = argparse.ArgumentParser()
+ parser.add_argument ("dir", action="store", help="Path to Doxygen's XML doc directory")
+ parser.add_argument ("--noerror", action="store_true", help="Do not return error code after execution")
+ parser.add_argument ("--threshold", action="store", help="Min acceptable coverage percentage (Default: %s)"%(ACCEPTABLE_COVERAGE), default=ACCEPTABLE_COVERAGE, type=int)
+ parser.add_argument("--excludedirs", nargs='+', help="List of directories to be excluded from coverage analysis", type=str, default=[])
+
+
+ global ns
+ ns = parser.parse_args()
+ if not ns:
+ FATAL ("ERROR: Couldn't parse parameters")
+
+ # Parse
+ files = parse (ns.dir)
+
+ # Print report
+ err = report (files, ns.excludedirs)
+ if ns.noerror:
+ return
+
+ sys.exit(err)
+
+
+if __name__ == "__main__":
+ main()