Try checking MGLComputedShapeSourcesupstream/nb-warn-attribute-loss-11287

1 files changed, 16 insertions, 0 deletions

diff --git a/platform/darwin/src/MGLComputedShapeSource.mm b/platform/darwin/src/MGLComputedShapeSource.mm
index 609db7f399..5c8da74ac4 100644
--- a/platform/darwin/src/MGLComputedShapeSource.mm
+++ b/platform/darwin/src/MGLComputedShapeSource.mm
@@ -131,6 +131,14 @@ mbgl::style::CustomGeometrySource::Options MBGLCustomGeometrySourceOptionsFromDi
         mbgl::FeatureCollection featureCollection;
         featureCollection.reserve(data.count);
         for (MGLShape <MGLFeature> * feature in data) {
+            if ([feature isMemberOfClass:[MGLShapeCollection class]]) {
+                static dispatch_once_t onceToken;
+                dispatch_once(&onceToken, ^{
+                    NSLog(@"MGLShapeCollection initialized with MGLFeatures will not retain attributes."
+                          @"Use MGLShapeCollectionFeature to retain attributes instead."
+                          @"This will be logged only once.");
+                });
+            }
             mbgl::Feature geoJsonObject = [feature geoJSONObject].get<mbgl::Feature>();
             featureCollection.push_back(geoJsonObject);
         }
@@ -196,6 +204,14 @@ mbgl::style::CustomGeometrySource::Options MBGLCustomGeometrySourceOptionsFromDi
     for (MGLShape <MGLFeature> * feature in features) {
         mbgl::Feature geoJsonObject = [feature geoJSONObject].get<mbgl::Feature>();
         featureCollection.push_back(geoJsonObject);
+        if ([feature isMemberOfClass:[MGLShapeCollection class]]) {
+            static dispatch_once_t onceToken;
+            dispatch_once(&onceToken, ^{
+                NSLog(@"MGLShapeCollection initialized with MGLFeatures will not retain attributes."
+                      @"Use MGLShapeCollectionFeature to retain attributes instead."
+                      @"This will be logged only once.");
+            });
+        }
     }
     const auto geojson = mbgl::GeoJSON{featureCollection};
     static_cast<mbgl::style::CustomGeometrySource *>(self.rawSource)->setTileData(tileID, geojson);