diff options
author | Bruno de Oliveira Abinader <bruno@mapbox.com> | 2017-05-12 16:14:32 +0300 |
---|---|---|
committer | Bruno de Oliveira Abinader <bruno@mapbox.com> | 2017-05-12 18:07:36 +0300 |
commit | baeaad83a3a3e00460b28a0afded18b8f1b83efc (patch) | |
tree | 78b293595324804e964aa8c26a186f9e8b741ae1 | |
parent | 1e1da36123c4520846e0318fcb71551573b54e18 (diff) | |
download | qtlocation-mapboxgl-baeaad83a3a3e00460b28a0afded18b8f1b83efc.tar.gz |
[tidy] modernize-use-emplace
-rw-r--r-- | platform/node/src/node_map.cpp | 4 | ||||
-rw-r--r-- | test/tile/annotation_tile.test.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp index 1c8bf6d1d2..680de6f90c 100644 --- a/platform/node/src/node_map.cpp +++ b/platform/node/src/node_map.cpp @@ -278,7 +278,7 @@ NodeMap::RenderOptions NodeMap::ParseOptions(v8::Local<v8::Object> obj) { const int length = classes->Length(); options.classes.reserve(length); for (int i = 0; i < length; i++) { - options.classes.push_back(std::string { *Nan::Utf8String(Nan::To<v8::String>(Nan::Get(classes, i).ToLocalChecked()).ToLocalChecked()) }); + options.classes.emplace_back(std::string { *Nan::Utf8String(Nan::To<v8::String>(Nan::Get(classes, i).ToLocalChecked()).ToLocalChecked()) }); } } @@ -947,7 +947,7 @@ void NodeMap::QueryRenderedFeatures(const Nan::FunctionCallbackInfo<v8::Value>& auto layers = layersOption.As<v8::Array>(); std::vector<std::string> layersVec; for (uint32_t i=0; i < layers->Length(); i++) { - layersVec.push_back(*Nan::Utf8String(Nan::Get(layers,i).ToLocalChecked())); + layersVec.emplace_back(*Nan::Utf8String(Nan::Get(layers,i).ToLocalChecked())); } queryOptions.layerIDs = layersVec; } diff --git a/test/tile/annotation_tile.test.cpp b/test/tile/annotation_tile.test.cpp index 4d71c5b0b4..607a8cca17 100644 --- a/test/tile/annotation_tile.test.cpp +++ b/test/tile/annotation_tile.test.cpp @@ -45,7 +45,7 @@ TEST(AnnotationTile, Issue8289) { auto data = std::make_unique<AnnotationTileData>(); data->layers.emplace("test", AnnotationTileLayer("test")); - data->layers.at("test").features.push_back(AnnotationTileFeature(0, FeatureType::Point, GeometryCollection())); + data->layers.at("test").features.emplace_back(0, FeatureType::Point, GeometryCollection()); // Simulate layout and placement of a symbol layer. tile.onLayout(GeometryTile::LayoutResult { |