diff options
author | Jason Wray <jason@mapbox.com> | 2016-01-22 19:16:49 -0500 |
---|---|---|
committer | Jason Wray <jason@mapbox.com> | 2016-01-25 14:59:38 -0500 |
commit | 9418f9a9870dc5b23c150fa9dc017e101582db30 (patch) | |
tree | f936063a212aa0943a10e5b2bac809eba7f9efbb | |
parent | 2f86467586706d254fcbcb1c88657992214aefcd (diff) | |
download | qtlocation-mapboxgl-9418f9a9870dc5b23c150fa9dc017e101582db30.tar.gz |
[ios] Avoid the blue background location status bar
Apps with `whenInUse` location permission will show a blue status bar
when they continue to use location services after leaving the
foreground. This is worrying and to be avoided, so let's disable telemetry
location services in this situation.
Fixes #2945
-rw-r--r-- | CHANGELOG.md | 1 | ||||
-rw-r--r-- | platform/ios/src/MGLMapboxEvents.m | 25 |
2 files changed, 19 insertions, 7 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 34ed73073c..3561c9f9e1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -66,6 +66,7 @@ Known issues: - Fixed an issue with users not being counted by Mapbox if they had disabled telemetry. ([#3495](https://github.com/mapbox/mapbox-gl-native/pull/3495)) - Fixed crash caused by MGLAnnotationImage with non-integer width or height ([#2198](https://github.com/mapbox/mapbox-gl-native/issues/2198)) - Fixed “include of non-modular header” errors in Swift projects managed by CocoaPods. ([#3679](https://github.com/mapbox/mapbox-gl-native/pull/3679)) +- Avoids triggering the blue background location status bar when user has granted "when in use" permission. ([#3671](https://github.com/mapbox/mapbox-gl-native/issues/3671)) ## iOS 3.0.1 diff --git a/platform/ios/src/MGLMapboxEvents.m b/platform/ios/src/MGLMapboxEvents.m index 8aa790c41f..8138d29169 100644 --- a/platform/ios/src/MGLMapboxEvents.m +++ b/platform/ios/src/MGLMapboxEvents.m @@ -336,13 +336,24 @@ const NSTimeInterval MGLFlushInterval = 60; if (self.paused) { [self stopUpdatingLocation]; } else { - CLAuthorizationStatus authStatus = [CLLocationManager authorizationStatus]; - if (authStatus == kCLAuthorizationStatusDenied || - authStatus == kCLAuthorizationStatusRestricted) { - [self stopUpdatingLocation]; - } else if (authStatus == kCLAuthorizationStatusAuthorized || - authStatus == kCLAuthorizationStatusAuthorizedWhenInUse) { - [self startUpdatingLocation]; + switch ([CLLocationManager authorizationStatus]) { + case kCLAuthorizationStatusNotDetermined: + case kCLAuthorizationStatusRestricted: + case kCLAuthorizationStatusDenied: + [self stopUpdatingLocation]; + break; + case kCLAuthorizationStatusAuthorized: + // Also handles kCLAuthorizationStatusAuthorizedAlways + [self startUpdatingLocation]; + break; + case kCLAuthorizationStatusAuthorizedWhenInUse: + if (UIApplication.sharedApplication.applicationState == UIApplicationStateBackground) { + // Prevent blue status bar when app is not in foreground + [self stopUpdatingLocation]; + } else { + [self startUpdatingLocation]; + } + break; } } } |