summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThiago Marcos P. Santos <tmpsantos@gmail.com>2019-08-09 19:11:38 +0300
committerThiago Marcos P. Santos <tmpsantos@gmail.com>2019-09-17 12:28:55 +0300
commit1304502f8182573176352bcab167d08963ba4c67 (patch)
treeb843f1369a8372244459cb8925823c6f264427f1
parentc507cc4c8a24616ebd71d8d28aa3017f2850cd52 (diff)
downloadqtlocation-mapboxgl-1304502f8182573176352bcab167d08963ba4c67.tar.gz
[build] Fix iOS nits
- Hardcoded the bundle identifier on Info.plist, CMake is not picking it up. - Do not use installed headers when building the framework.
-rw-r--r--platform/ios/app/MBXOrnamentsViewController.m2
-rw-r--r--platform/ios/app/MBXViewController.m2
-rw-r--r--platform/ios/framework/Info.plist2
-rw-r--r--platform/ios/src/MGLCompassButton.mm2
-rw-r--r--platform/ios/src/MGLCompassButton_Private.h2
-rw-r--r--platform/ios/src/MGLScaleBar.mm2
-rw-r--r--platform/ios/src/UIImage+MGLAdditions.h2
-rw-r--r--platform/macos/src/MGLAnnotationImage_Private.h2
8 files changed, 8 insertions, 8 deletions
diff --git a/platform/ios/app/MBXOrnamentsViewController.m b/platform/ios/app/MBXOrnamentsViewController.m
index 861d5d7678..09ae787503 100644
--- a/platform/ios/app/MBXOrnamentsViewController.m
+++ b/platform/ios/app/MBXOrnamentsViewController.m
@@ -1,6 +1,6 @@
#import "MBXOrnamentsViewController.h"
-@import Mapbox;
+#import <Mapbox/Mapbox.h>
@interface MBXOrnamentsViewController ()<MGLMapViewDelegate>
diff --git a/platform/ios/app/MBXViewController.m b/platform/ios/app/MBXViewController.m
index 346a182a88..31a2ff1d6d 100644
--- a/platform/ios/app/MBXViewController.m
+++ b/platform/ios/app/MBXViewController.m
@@ -729,7 +729,7 @@ CLLocationCoordinate2D randomWorldCoordinate() {
acrossDistance:100
pitch:60
heading:0];
- __weak typeof(self) weakSelf = self;
+ __weak MBXViewController *weakSelf = self;
[self.mapView setCamera:camera withDuration:0.3 animationTimingFunction:nil completionHandler:^{
[weakSelf.mapView setContentInset:contentInsets animated:YES completionHandler:nil];
}];
diff --git a/platform/ios/framework/Info.plist b/platform/ios/framework/Info.plist
index d8962c53ab..64bff94b78 100644
--- a/platform/ios/framework/Info.plist
+++ b/platform/ios/framework/Info.plist
@@ -7,7 +7,7 @@
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
- <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
+ <string>com.mapbox.core</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
diff --git a/platform/ios/src/MGLCompassButton.mm b/platform/ios/src/MGLCompassButton.mm
index acb25a560c..5bbd9bf923 100644
--- a/platform/ios/src/MGLCompassButton.mm
+++ b/platform/ios/src/MGLCompassButton.mm
@@ -1,7 +1,7 @@
#import "MGLCompassButton_Private.h"
#import "MGLCompassDirectionFormatter.h"
-#import <Mapbox/MGLGeometry.h>
+#import "MGLGeometry.h"
#import "MGLMapView_Private.h"
#import "UIImage+MGLAdditions.h"
diff --git a/platform/ios/src/MGLCompassButton_Private.h b/platform/ios/src/MGLCompassButton_Private.h
index c9741d79e3..9ef55cfa5b 100644
--- a/platform/ios/src/MGLCompassButton_Private.h
+++ b/platform/ios/src/MGLCompassButton_Private.h
@@ -1,6 +1,6 @@
#import <UIKit/UIKit.h>
-#import <Mapbox/MGLCompassButton.h>
+#import "MGLCompassButton.h"
@class MGLMapView;
diff --git a/platform/ios/src/MGLScaleBar.mm b/platform/ios/src/MGLScaleBar.mm
index cd8bc1d030..8525881da7 100644
--- a/platform/ios/src/MGLScaleBar.mm
+++ b/platform/ios/src/MGLScaleBar.mm
@@ -1,4 +1,4 @@
-#import <Mapbox/Mapbox.h>
+#import "Mapbox.h"
#import "MGLScaleBar.h"
static const CGFloat MGLFeetPerMile = 5280;
diff --git a/platform/ios/src/UIImage+MGLAdditions.h b/platform/ios/src/UIImage+MGLAdditions.h
index 55835c50d6..23fac9dbeb 100644
--- a/platform/ios/src/UIImage+MGLAdditions.h
+++ b/platform/ios/src/UIImage+MGLAdditions.h
@@ -1,6 +1,6 @@
#import <UIKit/UIKit.h>
-#import <Mapbox/MGLTypes.h>
+#import "MGLTypes.h"
#include <mbgl/style/image.hpp>
diff --git a/platform/macos/src/MGLAnnotationImage_Private.h b/platform/macos/src/MGLAnnotationImage_Private.h
index 21963a86a0..428f1db5d9 100644
--- a/platform/macos/src/MGLAnnotationImage_Private.h
+++ b/platform/macos/src/MGLAnnotationImage_Private.h
@@ -1,4 +1,4 @@
-#import <Mapbox/Mapbox.h>
+#import "Mapbox.h"
@interface MGLAnnotationImage (Private)