summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThiago Marcos P. Santos <tmpsantos@gmail.com>2020-03-27 18:30:35 +0200
committerThiago Marcos P. Santos <tmpsantos@gmail.com>2020-04-17 13:36:50 +0300
commit6559fa82a7905fd7bfe702f99bf81f07ca39299f (patch)
treed2e7891b0dc0ec9ba094c1b4e8d9793381364b4c
parenta1e5bffa90b8846d709e49efa80e1293d89d8d16 (diff)
downloadqtlocation-mapboxgl-6559fa82a7905fd7bfe702f99bf81f07ca39299f.tar.gz
[core] Fix readability-redundant-smartptr-get errors in header files
As reported by clang-tidy-8.
-rw-r--r--include/mbgl/style/color_ramp_property_value.hpp2
-rw-r--r--include/mbgl/util/image.hpp4
2 files changed, 2 insertions, 4 deletions
diff --git a/include/mbgl/style/color_ramp_property_value.hpp b/include/mbgl/style/color_ramp_property_value.hpp
index bc5639c899..1b9385f85f 100644
--- a/include/mbgl/style/color_ramp_property_value.hpp
+++ b/include/mbgl/style/color_ramp_property_value.hpp
@@ -27,7 +27,7 @@ public:
ColorRampPropertyValue() : value(nullptr) {}
ColorRampPropertyValue(std::shared_ptr<expression::Expression> value_) : value(std::move(value_)) {}
- bool isUndefined() const { return value.get() == nullptr; }
+ bool isUndefined() const { return value == nullptr; }
// noop, needed for batch evaluation of paint property values to compile
template <typename Evaluator>
diff --git a/include/mbgl/util/image.hpp b/include/mbgl/util/image.hpp
index e997c02223..75a49550b1 100644
--- a/include/mbgl/util/image.hpp
+++ b/include/mbgl/util/image.hpp
@@ -56,9 +56,7 @@ public:
return !(lhs == rhs);
}
- bool valid() const {
- return !size.isEmpty() && data.get() != nullptr;
- }
+ bool valid() const { return !size.isEmpty() && data != nullptr; }
template <typename T = Image>
T clone() const {