summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Morris <mikemorris@users.noreply.github.com>2016-02-03 15:44:47 -0500
committerMike Morris <mikemorris@users.noreply.github.com>2016-02-04 18:27:52 -0500
commit86691a08de77a5cfee2ba715b0b5cd138fbf9de4 (patch)
tree265ccec10ad77d8107c60105939974ba67b90f25
parent48dbd48e772c4f770eddd75bef1eee298480a06a (diff)
downloadqtlocation-mapboxgl-86691a08de77a5cfee2ba715b0b5cd138fbf9de4.tar.gz
[node] patch memory leak in NodeMap::request
Creating a v8::Function with Nan::GetFunction(Nan::New<v8::FunctionTemplate>) can leak, use Nan::New<v8::Function> instead. https://code.google.com/p/chromium/issues/detail?id=272579
-rw-r--r--platform/node/src/node_map.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp
index f5ebae110d..b8927ea334 100644
--- a/platform/node/src/node_map.cpp
+++ b/platform/node/src/node_map.cpp
@@ -462,7 +462,7 @@ std::unique_ptr<mbgl::FileRequest> NodeMap::request(const mbgl::Resource& resour
Nan::HandleScope scope;
auto requestHandle = NodeRequest::Create(res, cb2)->ToObject();
- auto callbackHandle = Nan::GetFunction(Nan::New<v8::FunctionTemplate>(NodeRequest::Respond, requestHandle)).ToLocalChecked();
+ auto callbackHandle = Nan::New<v8::Function>(NodeRequest::Respond, requestHandle);
v8::Local<v8::Value> argv[] = { requestHandle, callbackHandle };
Nan::MakeCallback(handle()->GetInternalField(1)->ToObject(), "request", 2, argv);