Fix errors recently introduced. (#1448)

* Fix bad references on tests for BigInt TypedArrays

* Remove bad conversions for BigInt TypedArray

* Cleanup the BigInt TypedArray harness file

Remove non used code (testBigIntTypedArrayConversions)

Move the constructors list to inside the exposed function, this prevents early implementations to fail before the function is called.

* Fix bad references in TypedArrays.of (BigInt)

* Remove BigInt tests from typedarray harness test

* Use BigInt for BigInt typedArrays

* Apply last fixings on BigInt TypedArray tests

* Apply fixes to last revision from @anba

2 files changed, 2 insertions, 62 deletions

diff --git a/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values-nan.js b/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values-nan.js
deleted file mode 100644
index 7a553b13e..000000000
--- a/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values-nan.js
+++ /dev/null
@@ -1,38 +0,0 @@
-// Copyright (C) 2016 the V8 project authors. All rights reserved.
-// This code is governed by the BSD license found in the LICENSE file.
-/*---
-esid: sec-%typedarray%.prototype.sort
-description: Sort values to numeric ascending order
-info: |
-  22.2.3.26 %TypedArray%.prototype.sort ( comparefn )
-
-  When the TypedArray SortCompare abstract operation is called with two
-  arguments x and y, the following steps are taken:
-
-  ...
-
-  NOTE: Because NaN always compares greater than any other value, NaN property
-  values always sort to the end of the result when comparefn is not provided.
-includes: [testBigIntTypedArray.js, compareArray.js]
-features: [BigInt, TypedArray]
----*/
-
-testWithBigIntTypedArrayConstructors(function(TA) {
-  var sample;
-
-  sample = new TA([2, NaN, NaN, 0, 1]).sort();
-  assert.sameValue(sample[0], 0, "#1 [0]");
-  assert.sameValue(sample[1], 1, "#1 [1]");
-  assert.sameValue(sample[2], 2, "#1 [2]");
-  assert.sameValue(sample[3], NaN, "#1 [3]");
-  assert.sameValue(sample[4], NaN, "#1 [4]");
-
-  sample = new TA([3, NaN, NaN, Infinity, 0, -Infinity, 2]).sort();
-  assert.sameValue(sample[0], -Infinity, "#2 [0]");
-  assert.sameValue(sample[1], 0, "#2 [1]");
-  assert.sameValue(sample[2], 2, "#2 [2]");
-  assert.sameValue(sample[3], 3, "#2 [3]");
-  assert.sameValue(sample[4], Infinity, "#2 [4]");
-  assert.sameValue(sample[5], NaN, "#2 [5]");
-  assert.sameValue(sample[6], NaN, "#2 [6]");
-}, [Float64Array, Float32Array]);
diff --git a/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values.js b/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values.js
index 57b491551..79b7e5469 100644
--- a/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values.js
+++ b/test/built-ins/TypedArray/prototype/sort/BigInt/sorted-values.js
@@ -25,29 +25,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   sample = new TA([3n, 4n, 3n, 1n, 0n, 1n, 2n]).sort();
   assert(compareArray(sample, [0n, 1n, 1n, 2n, 3n, 3n, 4n]), "repeating numbers");
-
-  sample = new TA([1n, 0n, -0n, 2n]).sort();
-  assert(compareArray(sample, [0n, 0n, 1n, 2n]), "0s");
 });
 
-testWithBigIntTypedArrayConstructors(function(TA) {
-  var sample = new TA([-4, 3, 4, -3, 2, -2, 1, 0]).sort();
-  assert(compareArray(sample, [-4, -3, -2, 0, 1, 2, 3, 4]), "negative values");
-}, [Float64Array, Float32Array, Int8Array, Int16Array, Int32Array]);
-
-testWithBigIntTypedArrayConstructors(function(TA) {
-  var sample;
-
-  sample = new TA([0.5, 0, 1.5, 1]).sort();
-  assert(compareArray(sample, [0, 0.5, 1, 1.5]), "non integers");
-
-  sample = new TA([0.5, 0, 1.5, -0.5, -1, -1.5, 1]).sort();
-  assert(compareArray(sample, [-1.5, -1, -0.5, 0, 0.5, 1, 1.5]), "non integers + negatives");
-
-  sample = new TA([1, 0, -0, 2]).sort();
-  assert(compareArray(sample, [0, 0, 1, 2]), "0 and -0");
-
-  sample = new TA([3, 4, Infinity, -Infinity, 1, 2]).sort();
-  assert(compareArray(sample, [-Infinity, 1, 2, 3, 4, Infinity]), "infinities");
-
-}, [Float64Array, Float32Array]);
+var sample = new BigInt64Array([-4n, 3n, 4n, -3n, 2n, -2n, 1n, 0n]).sort();
+assert(compareArray(sample, [-4n, -3n, -2n, 0n, 1n, 2n, 3n, 4n]), "negative values");