| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: Iadd9905f4129ede5f0c06b1e1a88a8f932c37c70
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
|
|\
| |
| |
| | |
Change-Id: I25358eae40c07d8e5ba1224b3508c5fee95d3a85
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
While discovering descriptors, when handles are not numbered
sequentially, the discovery stopped as soon as "no attribute in given
range found" error is received. However, there could be more
characteristics pending. As a result, descriptors for those
characteristics where never discovered.
Change-Id: Iad9d7203020b0787f1d4571fc7063ef390448ce9
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|/
|
|
|
| |
Change-Id: I1422ab23ef1abd812eb5523105cbadc8ef1aa015
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
|
|
|
|
|
|
|
| |
Otherwise, a malicious device could crash our application.
Change-Id: I427eb1ff88b08710d5c74230f5877b0c59b6fb0f
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Ib5a9f4e5c0eef85a1acd93454d842bbb0d615751
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Ic1f3ca5075174addfbc6d76f31d9b89d2c654d19
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
The previous code always returned the id of the first device in the
list.
Change-Id: I6f3cde2405d53eab009d7409d9e3c6b47d97e53b
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
The private class used a member in its constructor that was only set
afterwards.
Change-Id: I19b7ca2a5048771a447d63a56ad10ad56c311e91
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I59c6344b1c1ab0c892d8c66a7348f8321e3a603e
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-50345
Change-Id: I721b98f9b6ccff2a987a6c477d08902332ce848c
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
| |
Now we have this class in QtCore, no need in my "home-made" version anymore.
Change-Id: Id26944dd6970cc2a8ac9d02675f8af9adecc3d44
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
This may happen when the app name contains for example a dash ('-').
Task-number: QTBUG-49402
Change-Id: I04b289b0723e2979a67c93e335205556bf1eb30e
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
This is important on Android as not all error conditions are exposed
via QLowEnergyController::Error enum.
Change-Id: I442ecffcadc01e1a2b60ae17dc6e63e08e5f4149
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I3addd4258e3bbb5aaa6eca21af338aab57b9cf33
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Iec9163b25f961a5f7371150aba17a892e5fac305
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
So far, invalidation only took place when the local/central side
disconnected the connection.
Task-number: QTBUG-50125
Change-Id: Ic01725d1b83e49ad7df6971d980b480f839d550b
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Most likely it was used before some changes rendered it unused.
At this point the variable was initialized to false and never ever
set to true.
Change-Id: I5b60cf83bc362ff53f8ce276c16392aada9efc69
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
So far, only a local disconnect triggered the invalidation process.
Task-number: QTBUG-50125
Change-Id: I324e01c86eb0c7cc820e91a6f6d6d01fb23170ab
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I0baa4bbbc5d398f388a1e0aff9ba88f82a23c1cc
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: Iefea81376d0486aead874dad985e55f0b0af5d27
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
| |
Fixes coverity CID22012.
Change-Id: Ifdadf0330c277aeea6f87bacd986ec15d5a0c144
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
| |
Fixes coverity CID21692.
Change-Id: I6c4d464c54caae826cef1af25334a03037971ef8
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
Do not leak the private object.
Fixes coverity CID21656.
Change-Id: I19873364afeb4f8244c2f436129ad82d83491a2a
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I4005833edebd10b778ac06ded49a88e633e5f435
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I85312373f8feca9f117faf8c4b0f0f517c33e9f3
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I095fbdfff6ba753c5c9bfbf204b3ac70d8108376
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ATM CBCentralManager's delegate does its work on the main queue. With
CoreFoundation event dispatcher it's now possible to use QtBluetooth from
non-gui thread (more generally - from a thread other than main).
This makes main queue useless - and we have to move to a dedicated dispatch
queue. Also, we have to make sure we do not have race conditioins/dead-locks.
This patch:
1. decouples OSXBTLECentralManager and QLowEnergyController so that these
two objects working (potentially) on different threads do not share any data
and do not have to use locks, removes the explicit 'delegate' interface/inheritance
and replaces them with LECentralNotifier class - to be able to use Qt's signal/slot mechanics
for inter-thread communication.
2. all OSXBTLECentralManager's are now executed on qt_LE_queue queue
to avoid any race-conditions (since they potentially update manager's
internal state).
3. Results/errors are now reported using LECentralNotifier's object
(QLowEnergyController has corresponding slots connected to the notifier)
Task-number: QTBUG-49476
Change-Id: Ie07cdc13ad559c96a7d2ff010843fb7bcce07c99
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I48acb0f4bcac1cc98d74b2793151e62f2051d7c9
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Braodcast -> Broadcast
subsequemtly -> subsequently
discovred -> discovered
Change-Id: I1e9d83bb0b33ad15da1f05d8a7cdd8ba82232f42
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|\
| |
| |
| | |
Change-Id: I4404df69bfdac335e9c1eb63e4ada3ba89b48b6c
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The QMetaType register my not be up and running by the time
we attempt these meta type registration.
Change-Id: I1a857a936a24b4b00a49574fac311c08c09b3d5a
Task-number: QTBUG-49455
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The GATT protocol does not enforce a length indicator on each GATT
command. Usually this is not a problem because each request is followed
by a response and therefore we can assume the entire packet content is
a single response/request.
However the GATT WRITE_COMMAND does not have a response. Multiple
requests can be sent in quick follow-up. If buffering is utilized the
consecutive commands may be merged and received as single data blob on
the remote device. Since Write commands don't have a length indicator
they cannot be distinguished and ultimately the write command will set
the wrong value.
Change-Id: I02f3cd3cfaedfeae6a40272f5d22d3d88c39aa55
Task-number: QTBUG-49650
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Authorization in the context of ATT is purely a server-side feature that
the client cannot influence, so increasing the security level will not
help. The "Insufficient key size" error, however, should be handled.
Change-Id: I14b24700f3ebc365215eefb78b0aa8487fcbfd4d
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Move CBCentralManager's delegate to its own dispatch queue, not the main one,
so that even if somebody _blocks_ the main thread somehow, waiting for discovery
to finish, the discovery can, indeed, finish. Also, make DDA aware of the fact
that now actual scan and 'this' are working on different threads, thus we must
be thread-safe.
Task-number: QTBUG-49476
Change-Id: I9bcc74131f51389c8a014577c65e0943bbc8da42
Reviewed-by: Morten Johan Sørvig <morten.sorvig@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Several tests were marked as 'insignificant' in the past, but nowadays
tests can deal with VMs without BT adapters.
Change-Id: If657b3723a9a3f88c9c638105a077fd7396931d8
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The build of the .jar files depends on the bluetooth and nfc modules
already being built, so we need to make sure the subdirs are visited
in the order specified.
Change-Id: I52617babd31608be5a51c069f74de30a9d2b6a15
Task-number: QTBUG-49367
Task-number: QTBUG-49512
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Create the LE scan timer when it's really needed,
so that I do not have to later move it between threads if somebody
scans from a different thread.
Change-Id: I71669f4c1512432fc94f80446d400336d39def64
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The address is not exposed on OS X and iOS and deviceUuid() should be
used instead.
Task-number: QTBUG-48746
Change-Id: I07f837ae8a01303c7d1fe27b8a8c174f288829c9
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: Id3fe0f89966a60f2f34ff971ad26319e95de6ae9
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Also remove the default case from the switch so the next such oversight
causes a compiler warning.
Change-Id: If332a9a00698debb834462f442dddb0dac40b83d
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-38916
Change-Id: Ibd425ca24a1a98433f7b9d8b1fa11a7c287de871
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Change-Id: Ibd0da6662aca93d9ddd9d0a71b6ec81d983e2900
Task-number: QTBUG-43810
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Replace pendingStart and isActive + all places they have to be modified
with scanPhase and enum {startingScan, activeScan, noActivity}.
Change-Id: I29edff3b99fc877d0d52a5974aa64c9ff2faa584
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On iOS when we receive centralManagerDidUpdateState with the state
== PoweredOff, iOS also shows an alert on screen, asking to enable
Bluetooth via the "Settings" app. If we do not report an error and
a user indeed enables BT, we can continue to work.
Change-Id: Ic1f63f205b56fc356bc7fa645359b583c00195a6
Task-number: QTBUG-48713
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| | |
There's no reason they should be outside.
Change-Id: I597c7c07857c9af820fcdb93e1587f62a2064ab3
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The examplesinstallpath variable in .qdocconf files defines the path
under QT_INSTALL_EXAMPLES where examples are found.
To match the way examples are packaged in Qt 5.6, prefix the
install path with the repository name.
Task-number: QTBUG-48736
Change-Id: I3452cf1ec1b1f16301497eb5468bd746d99e5cbc
Reviewed-by: Venugopal Shivashankar <venugopal.shivashankar@digia.com>
|
| |
| |
| |
| |
| | |
Change-Id: I2239624dd411daf400e987ec092be48805b8fa57
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
In most cases, callers of convertAddress() feed the result into a
QBluetoothAddress, so they have no need for the output parameter.
Change-Id: I23b2e8d5d49ac300c35d141b75ffa8e398e22f19
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: I9d78ba7ad02848e3166a29c9f2d4876dd1bc1e96
|