diff options
| author | Sze Howe Koh <szehowe.koh@gmail.com> | 2023-01-24 15:24:56 +0800 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-02-02 13:53:41 +0000 |
| commit | 30786ef5964c3db3c1c7e1a56f8ed6acfed1ac51 (patch) | |
| tree | ccde140dc9f84e146f64e75770b69c2287a2b12a | |
| parent | 9b8777d493ce7f480a65601cffa8223c30b17207 (diff) | |
| download | qtbase-30786ef5964c3db3c1c7e1a56f8ed6acfed1ac51.tar.gz | |
QAnyStringView: fix MSVC warning C4702
The previous fix attempt at 8ba8d1346a562347c398bdd0529d34f94f2ac698
does not work when C++20 mode is enabled.
MSVC optimizes away the "else" block but triggers warning C4702 on
"return true". Moving the return line into the "else" block ensures that
it is optimized away too.
Change-Id: I9ef02cd3631ff78091530b6fb2b91c2eddcbab5d
Fixes: QTBUG-104836
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Yuhang Zhao <yuhangzhao@deepin.org>
(cherry picked from commit 4bfdf6a3d156184579e9fc66224754a6e66159dd)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/corelib/text/qanystringview.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/text/qanystringview.h b/src/corelib/text/qanystringview.h index 2601ce748d..b1af305d0d 100644 --- a/src/corelib/text/qanystringview.h +++ b/src/corelib/text/qanystringview.h @@ -72,8 +72,8 @@ private: if (uchar(str[i]) > 0x7f) return false; } + return true; } - return true; #endif } |