diff options
author | Joerg Bornemann <joerg.bornemann@qt.io> | 2022-01-04 14:30:46 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-01-08 20:02:22 +0000 |
commit | 8fe51e489ba19374431b932572c4fcac7214b21e (patch) | |
tree | 9c7ea572ba9e011d6d19ef7148b80c3451291210 | |
parent | 9794fc4e54806a1fc97bc8af21a5851de4da10f3 (diff) | |
download | qtbase-8fe51e489ba19374431b932572c4fcac7214b21e.tar.gz |
qmake/MinGW: Fix linking target name with whitespace
When having a TARGET value that contains whitespace, linking would fail
with MinGW. This was, because the function createResponseFile stitched
together a file name like this:
objectScript."Target Name".Release
The inner double quotes make the file name invalid.
Fix this by retrieving QMAKE_ORIG_TARGET with the var() method instead
of fileVar(). The latter quotes the return value if it contains
spaces.
Fixes: QTBUG-99522
Change-Id: Ieb7dcf3fbbd8a75de5a9b9a6beadb2170dddf35d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
(cherry picked from commit 7246058dfd7511e5732a6d74521ce4a717c73f70)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r-- | qmake/generators/makefile.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/qmake/generators/makefile.cpp b/qmake/generators/makefile.cpp index 92aa3fc849..59dc24f022 100644 --- a/qmake/generators/makefile.cpp +++ b/qmake/generators/makefile.cpp @@ -3500,7 +3500,7 @@ QString MakefileGenerator::createResponseFile( const ProStringList &objList, const QString &prefix) { - QString fileName = baseName + '.' + fileVar("QMAKE_ORIG_TARGET"); + QString fileName = baseName + '.' + var("QMAKE_ORIG_TARGET"); if (!var("BUILD_NAME").isEmpty()) fileName += '.' + var("BUILD_NAME"); if (!var("MAKEFILE").isEmpty()) |