summaryrefslogtreecommitdiff
path: root/src/activeqt/shared
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@digia.com>2014-10-06 16:06:01 +0200
committerFriedemann Kleint <Friedemann.Kleint@digia.com>2014-10-06 17:47:54 +0200
commit575ee40621f7632c6d82e628aa2817c3233de327 (patch)
treed71d7ec23cdf7bd9962d868e5db6c32b946ad6e1 /src/activeqt/shared
parent68dcc97d38871bba273181e8b0c55bd9c9be6780 (diff)
downloadqtactiveqt-575ee40621f7632c6d82e628aa2817c3233de327.tar.gz
Remove repeated invocations of end() in iterations.
Assign end() to a variable. Where possible, use foreach() to iterate over lists or map values or use Qt convenience APIs. Change-Id: Ie6a6f56d1b0ddb419d06a7ccf4be2f8b32c029b4 Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/activeqt/shared')
-rw-r--r--src/activeqt/shared/qaxtypes.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/activeqt/shared/qaxtypes.cpp b/src/activeqt/shared/qaxtypes.cpp
index 1697686..6eba133 100644
--- a/src/activeqt/shared/qaxtypes.cpp
+++ b/src/activeqt/shared/qaxtypes.cpp
@@ -1246,9 +1246,8 @@ QVariant VARIANTToQVariant(const VARIANT &arg, const QByteArray &typeName, uint
} else if (proptype == QVariant::StringList && var.type() == QVariant::List) {
bool allStrings = true;
QStringList strings;
- const QList<QVariant> list(var.toList());
- for (QList<QVariant>::ConstIterator it(list.begin()); it != list.end(); ++it) {
- QVariant variant = *it;
+ const QVariantList list(var.toList());
+ foreach (const QVariant &variant, list) {
if (variant.canConvert(QVariant::String))
strings << variant.toString();
else