diff options
author | Paul Lemire <paul.lemire@kdab.com> | 2017-01-09 16:00:07 +0100 |
---|---|---|
committer | Paul Lemire <paul.lemire@kdab.com> | 2017-01-11 07:26:43 +0000 |
commit | 168df684faec35dd8422c03d53dc6954805c7425 (patch) | |
tree | 2bdeb0198cdc482aa7656fa3933f78bb1fefed68 | |
parent | a4ab9962239c692b302f0d75cfdec96359a8d33e (diff) | |
download | qt3d-168df684faec35dd8422c03d53dc6954805c7425.tar.gz |
Skybox: add documentation about issues with frustum culling
Also fix the examples to not perform frustum culling
Task-number: QTBUG-57989
Change-Id: If3755cad71158b62fffebdaeba41ba32e2b1d1ff
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
-rw-r--r-- | src/extras/defaults/qskyboxentity.cpp | 5 | ||||
-rw-r--r-- | tests/manual/skybox/main.qml | 2 | ||||
-rw-r--r-- | tests/manual/transparency-qml-scene3d/Scene.qml | 2 |
3 files changed, 7 insertions, 2 deletions
diff --git a/src/extras/defaults/qskyboxentity.cpp b/src/extras/defaults/qskyboxentity.cpp index e81c6ad91..32e68e6fc 100644 --- a/src/extras/defaults/qskyboxentity.cpp +++ b/src/extras/defaults/qskyboxentity.cpp @@ -201,7 +201,10 @@ void QSkyboxEntityPrivate::reloadTexture() * * By default the extension defaults to .png. * - * \note Please note that you shouldn't try to render skybox with an + * Be sure to disable frustum culling in the FrameGraph through which the + * skybox rendering happens. + * + * \note Please note that you shouldn't try to render a skybox with an * orthographic projection. * * \since 5.5 diff --git a/tests/manual/skybox/main.qml b/tests/manual/skybox/main.qml index d89df316e..af476a1ca 100644 --- a/tests/manual/skybox/main.qml +++ b/tests/manual/skybox/main.qml @@ -61,6 +61,8 @@ Entity { ForwardRenderer { camera: basicCamera clearColor: "black" + // Note: FrustumCulling should be disabled for proper rendering of the Skybox + frustumCulling: false } }, // Event Source will be set by the Qt3DQuickWindow diff --git a/tests/manual/transparency-qml-scene3d/Scene.qml b/tests/manual/transparency-qml-scene3d/Scene.qml index b029d23af..43d49dc54 100644 --- a/tests/manual/transparency-qml-scene3d/Scene.qml +++ b/tests/manual/transparency-qml-scene3d/Scene.qml @@ -76,6 +76,7 @@ Entity { activeFrameGraph: ForwardRenderer{ camera: camera clearColor: Qt.rgba(0.0, 0.5, 1, 1) + frustumCulling: false } }, InputSettings { } @@ -98,7 +99,6 @@ Entity { } SkyboxEntity { - cameraPosition: camera.position baseName: "qrc:/assets/cubemaps/miramar/miramar" extension: ".webp" } |