diff options
author | Tom Cooksey <thomas.cooksey@nokia.com> | 2010-01-29 11:39:06 +0100 |
---|---|---|
committer | Tom Cooksey <thomas.cooksey@nokia.com> | 2010-01-29 15:29:42 +0100 |
commit | 9e95ce2a68ef167e17dccc5789cbf3bf74712280 (patch) | |
tree | 1fc5e33c239a32905dfd6692292e363d6783b88e /src/gui/image/qpixmap_x11.cpp | |
parent | e2f9547983c15be88c0a096dd52cc7c7a0eac0c6 (diff) | |
download | qt4-tools-9e95ce2a68ef167e17dccc5789cbf3bf74712280.tar.gz |
Fix GL texture leaks when pixmaps are deleted
This fixes quite a lot of issues:
* QtOpenGL only registered qpixmap destruction hooks on X11 and
those only cleanup the EGL/GLX surface, not the texture object.
* The QPixmap destruction hooks were only being called from the
QPixmap destructor. However, this means when a QPixmap is assigned
to another QPixmap, the hooks don't get called.
Task-number: QTBUG-7647
Reviewed-By: Samuel
Reviewed-By: Trond
Diffstat (limited to 'src/gui/image/qpixmap_x11.cpp')
-rw-r--r-- | src/gui/image/qpixmap_x11.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/gui/image/qpixmap_x11.cpp b/src/gui/image/qpixmap_x11.cpp index 0e66e093c6..169a2ece26 100644 --- a/src/gui/image/qpixmap_x11.cpp +++ b/src/gui/image/qpixmap_x11.cpp @@ -68,6 +68,7 @@ #include "qx11info_x11.h" #include <private/qdrawhelper_p.h> #include <private/qimage_p.h> +#include <private/qimagepixmapcleanuphooks_p.h> #include <stdlib.h> @@ -1228,6 +1229,12 @@ void QX11PixmapData::fill(const QColor &fillColor) QX11PixmapData::~QX11PixmapData() { + // Cleanup hooks have to be called before the handles are freed + if (is_cached) { + QImagePixmapCleanupHooks::executePixmapDataDestructionHooks(this); + is_cached = false; + } + release(); } |