diff options
author | Kent Hansen <khansen@trolltech.com> | 2009-06-15 13:54:44 +0200 |
---|---|---|
committer | Kent Hansen <khansen@trolltech.com> | 2009-06-15 13:54:44 +0200 |
commit | 86b8daf2a0348be875cbd0b330ab7773f55a35dc (patch) | |
tree | 4e72cd1169b92a6117e654f277b69d5c754cf882 | |
parent | f3b534e5cdbcf7ed1bdd0dc3c258d26a8a3a87ab (diff) | |
download | qt4-tools-86b8daf2a0348be875cbd0b330ab7773f55a35dc.tar.gz |
make qscript unit tests not crash when test files are not found
-rw-r--r-- | tests/auto/qscriptjstestsuite/tst_qscriptjstestsuite.cpp | 8 | ||||
-rw-r--r-- | tests/auto/qscriptv8testsuite/tst_qscriptv8testsuite.cpp | 26 |
2 files changed, 18 insertions, 16 deletions
diff --git a/tests/auto/qscriptjstestsuite/tst_qscriptjstestsuite.cpp b/tests/auto/qscriptjstestsuite/tst_qscriptjstestsuite.cpp index fbb0ba5960..4807b3fe42 100644 --- a/tests/auto/qscriptjstestsuite/tst_qscriptjstestsuite.cpp +++ b/tests/auto/qscriptjstestsuite/tst_qscriptjstestsuite.cpp @@ -390,9 +390,9 @@ int tst_Suite::qt_metacall(QMetaObject::Call _c, int _id, void **_a) tst_Suite::tst_Suite() { testsDir = QDir("."); - if (!testsDir.cd("tests")) { + bool testsFound = testsDir.cd("tests"); + if (!testsFound) { qWarning("*** no tests/ dir!"); - return; } QString willFixInNextReleaseMessage = QString::fromLatin1("Will fix in next release"); @@ -802,7 +802,9 @@ tst_Suite::tst_Suite() // don't execute any tests on slow machines #if !defined(Q_OS_IRIX) // do all the test suites - QFileInfoList testSuiteDirInfos = testsDir.entryInfoList(QDir::AllDirs | QDir::NoDotAndDotDot); + QFileInfoList testSuiteDirInfos; + if (testsFound) + testSuiteDirInfos = testsDir.entryInfoList(QDir::AllDirs | QDir::NoDotAndDotDot); foreach (QFileInfo tsdi, testSuiteDirInfos) { QDir testSuiteDir(tsdi.absoluteFilePath()); // do all the dirs in the test suite diff --git a/tests/auto/qscriptv8testsuite/tst_qscriptv8testsuite.cpp b/tests/auto/qscriptv8testsuite/tst_qscriptv8testsuite.cpp index 435af41385..92027e6bfd 100644 --- a/tests/auto/qscriptv8testsuite/tst_qscriptv8testsuite.cpp +++ b/tests/auto/qscriptv8testsuite/tst_qscriptv8testsuite.cpp @@ -194,20 +194,18 @@ int tst_Suite::qt_metacall(QMetaObject::Call _c, int _id, void **_a) tst_Suite::tst_Suite() { testsDir = QDir("."); - if (!testsDir.cd("tests")) { + bool testsFound = testsDir.cd("tests"); + if (!testsFound) { qWarning("*** no tests/ dir!"); - return; - } - if (!testsDir.exists("mjsunit.js")) { - qWarning("*** no tests/mjsunit.js file!"); - return; - } - mjsunitContents = readFile(testsDir.absoluteFilePath("mjsunit.js")); - if (mjsunitContents.isEmpty()) { - qWarning("*** tests/mjsunit.js is empty!"); - return; + } else { + if (!testsDir.exists("mjsunit.js")) + qWarning("*** no tests/mjsunit.js file!"); + else { + mjsunitContents = readFile(testsDir.absoluteFilePath("mjsunit.js")); + if (mjsunitContents.isEmpty()) + qWarning("*** tests/mjsunit.js is empty!"); + } } - QString willFixInNextReleaseMessage = QString::fromLatin1("Will fix in next release"); addExpectedFailure("apply", "morundefineder", "morseper", willFixInNextReleaseMessage); addExpectedFailure("arguments-enum", "2", "0", willFixInNextReleaseMessage); @@ -270,7 +268,9 @@ tst_Suite::tst_Suite() appendCString(stringdata, "tst_Suite"); appendCString(stringdata, ""); - QFileInfoList testFileInfos = testsDir.entryInfoList(QStringList() << "*.js", QDir::Files); + QFileInfoList testFileInfos; + if (testsFound) + testFileInfos = testsDir.entryInfoList(QStringList() << "*.js", QDir::Files); foreach (QFileInfo tfi, testFileInfos) { QString name = tfi.baseName(); // slot: signature, parameters, type, tag, flags |