Fix uninitialized variables

This fixes most of clang analyzer warnings about uninitialized variables
in ctors

Change-Id: I879c785594307ed3fe7140588338a6b2a1e4db65
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

8 files changed, 22 insertions, 30 deletions

diff --git a/src/plugins/generator/visualstudio/io/msbuildprojectwriter.cpp b/src/plugins/generator/visualstudio/io/msbuildprojectwriter.cpp
index c5684e5ba..634bb2381 100644
--- a/src/plugins/generator/visualstudio/io/msbuildprojectwriter.cpp
+++ b/src/plugins/generator/visualstudio/io/msbuildprojectwriter.cpp
@@ -51,7 +51,7 @@ static const QString kMSBuildSchemaURI =
 class MSBuildProjectWriterPrivate : public IMSBuildNodeVisitor
 {
 public:
-    std::ostream *device;
+    std::ostream *device = nullptr;
     QByteArray buffer;
     std::unique_ptr<QXmlStreamWriter> writer;
 
diff --git a/src/plugins/generator/visualstudio/io/visualstudiosolutionwriter.cpp b/src/plugins/generator/visualstudio/io/visualstudiosolutionwriter.cpp
index 07e8d81b8..e980249d6 100644
--- a/src/plugins/generator/visualstudio/io/visualstudiosolutionwriter.cpp
+++ b/src/plugins/generator/visualstudio/io/visualstudiosolutionwriter.cpp
@@ -54,7 +54,7 @@ using namespace Internal;
 class VisualStudioSolutionWriterPrivate
 {
 public:
-    std::ostream *device;
+    std::ostream *device = nullptr;
     std::string baseDir;
 };
 
diff --git a/src/plugins/generator/visualstudio/msbuild/items/msbuildfilter.cpp b/src/plugins/generator/visualstudio/msbuild/items/msbuildfilter.cpp
index 3a5d98a98..f7c506651 100644
--- a/src/plugins/generator/visualstudio/msbuild/items/msbuildfilter.cpp
+++ b/src/plugins/generator/visualstudio/msbuild/items/msbuildfilter.cpp
@@ -44,8 +44,8 @@ public:
     QList<QString> extensions;
     bool parseFiles = true;
     bool sourceControlFiles = true;
-    MSBuildItemMetadata *identifierMetadata;
-    MSBuildItemMetadata *extensionsMetadata;
+    MSBuildItemMetadata *identifierMetadata = nullptr;
+    MSBuildItemMetadata *extensionsMetadata = nullptr;
 };
 
 MSBuildFilter::MSBuildFilter(IMSBuildItemGroup *parent)
diff --git a/src/plugins/generator/visualstudio/msbuildtargetproject.cpp b/src/plugins/generator/visualstudio/msbuildtargetproject.cpp
index 08315cc08..154f8dccc 100644
--- a/src/plugins/generator/visualstudio/msbuildtargetproject.cpp
+++ b/src/plugins/generator/visualstudio/msbuildtargetproject.cpp
@@ -46,8 +46,8 @@ class MSBuildTargetProjectPrivate
 public:
     MSBuildTargetProjectPrivate(const Internal::VisualStudioVersionInfo &versionInfo)
         : versionInfo(versionInfo) {}
-    MSBuildPropertyGroup *globalsPropertyGroup;
-    MSBuildProperty *projectGuidProperty;
+    MSBuildPropertyGroup *globalsPropertyGroup = nullptr;
+    MSBuildProperty *projectGuidProperty = nullptr;
     const Internal::VisualStudioVersionInfo &versionInfo;
 };
 
diff --git a/src/plugins/generator/visualstudio/visualstudiogenerator.cpp b/src/plugins/generator/visualstudio/visualstudiogenerator.cpp
index 04fc5a52e..ace55b6e6 100644
--- a/src/plugins/generator/visualstudio/visualstudiogenerator.cpp
+++ b/src/plugins/generator/visualstudio/visualstudiogenerator.cpp
@@ -144,8 +144,8 @@ public:
     }
 
 private:
-    VisualStudioGenerator *generator;
-    VisualStudioSolutionGlobalSection *nestedProjects;
+    VisualStudioGenerator *generator = nullptr;
+    VisualStudioSolutionGlobalSection *nestedProjects = nullptr;
 };
 
 VisualStudioGenerator::VisualStudioGenerator(const VisualStudioVersionInfo &versionInfo)
diff --git a/src/plugins/scanner/cpp/Lexer.h b/src/plugins/scanner/cpp/Lexer.h
index 2b843a14a..1cf829ebb 100644
--- a/src/plugins/scanner/cpp/Lexer.h
+++ b/src/plugins/scanner/cpp/Lexer.h
@@ -145,17 +145,17 @@ private:
         unsigned _objCEnabled: 1;
     };
 
-    const char *_firstChar;
-    const char *_currentChar;
-    const char *_lastChar;
-    const char *_tokenStart;
-    unsigned char _yychar;
-    int _state;
+    const char *_firstChar = nullptr;
+    const char *_currentChar = nullptr;
+    const char *_lastChar = nullptr;
+    const char *_tokenStart = nullptr;
+    unsigned char _yychar = 0;
+    int _state = 0;
     union {
         unsigned _flags;
         Flags f;
     };
-    unsigned _currentLine;
+    unsigned _currentLine = 0;
 };
 
 } // end of namespace CPlusPlus
diff --git a/src/plugins/scanner/cpp/Token.h b/src/plugins/scanner/cpp/Token.h
index 286c71a48..846aa5a12 100644
--- a/src/plugins/scanner/cpp/Token.h
+++ b/src/plugins/scanner/cpp/Token.h
@@ -353,7 +353,7 @@ public:
         Flags f;
     };
 
-    unsigned offset;
+    unsigned offset = 0;
 
     union {
         void *ptr;
diff --git a/src/plugins/scanner/qt/qtscanner.cpp b/src/plugins/scanner/qt/qtscanner.cpp
index 51faadab3..40d062e1f 100644
--- a/src/plugins/scanner/qt/qtscanner.cpp
+++ b/src/plugins/scanner/qt/qtscanner.cpp
@@ -68,24 +68,16 @@
 struct OpaqQrc
 {
 #ifdef Q_OS_UNIX
-    int fd;
-    int mapl;
+    int fd = 0;
+    int mapl = 0;
 #else
-    QFile *file;
+    QFile *file = nullptr;
 #endif
 
-    char *map;
-    QXmlStreamReader *xml;
+    char *map = nullptr;
+    QXmlStreamReader *xml = nullptr;
     QByteArray current;
-    OpaqQrc()
-#ifdef Q_OS_UNIX
-        : fd (0),
-#else
-        : file(nullptr),
-#endif
-          map(nullptr),
-          xml(nullptr)
-    {}
+    OpaqQrc() = default;
 
     ~OpaqQrc()
     {