diff options
| author | Christian Kandeler <christian.kandeler@digia.com> | 2012-11-05 13:48:32 +0100 |
|---|---|---|
| committer | Joerg Bornemann <joerg.bornemann@digia.com> | 2012-11-06 17:40:01 +0100 |
| commit | 36f4aa2dadf5964d222203ce02a973db47e6f096 (patch) | |
| tree | c0cb3137fbf462ea4d2c8630ed30c8f44cb8dc67 /src/lib/buildgraph/executor.h | |
| parent | db1a70a524dfb44eca43bab76c83bf56195e2684 (diff) | |
| download | qbs-36f4aa2dadf5964d222203ce02a973db47e6f096.tar.gz | |
Do product filtering at an earlier stage.
It is unintuitive and confusing to give the Sourceproject
and the Executor a list of projects as part of their build()
operations, when in reality just some products should be built.
So take the "selectedProducts" out of the Buildoptions and
do the filtering outside of the library. This way, we can tell
the API "build these projects" or "build these products" and
it will mean exactly that.
Change-Id: I88860a9cf7f4058145964b1b56b01e7970c9e8d0
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/lib/buildgraph/executor.h')
| -rw-r--r-- | src/lib/buildgraph/executor.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/lib/buildgraph/executor.h b/src/lib/buildgraph/executor.h index b65871928..062db233c 100644 --- a/src/lib/buildgraph/executor.h +++ b/src/lib/buildgraph/executor.h @@ -55,7 +55,7 @@ public: Executor(); ~Executor(); - void build(const QList<BuildProject::Ptr> projectsToBuild); + void build(const QList<BuildProduct::Ptr> &productsToBuild); void cancelBuild(); enum ExecutorState { @@ -120,7 +120,6 @@ private: ExecutorState m_state; BuildResult m_buildResult; bool m_printScanningMessage; - QList<BuildProject::Ptr> m_projectsToBuild; QList<BuildProduct::Ptr> m_productsToBuild; QList<Artifact *> m_roots; QMap<Artifact *, QHashDummyValue> m_leaves; |
