Fix meaning of "Command.silent".

The new, saner meaning is: If this property is set to true, then qbs
will not print the status message (containing the command description).
Accordingly, the default is changed to false. Also, there is now a
check that prints a warning if a non-silent command has an empty
description.

Change-Id: I5a8fd4e2f8901f6e2858946901e8081a6929d43f
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

1 files changed, 3 insertions, 1 deletions

diff --git a/src/lib/buildgraph/command.h b/src/lib/buildgraph/command.h
index 40ec2e768..39546cf05 100644
--- a/src/lib/buildgraph/command.h
+++ b/src/lib/buildgraph/command.h
@@ -53,7 +53,7 @@ public:
     static AbstractCommand *createByType(CommandType commandType);
     static QString defaultDescription() { return QString(); }
     static QString defaultHighLight() { return QString(); }
-    static bool defaultIsSilent() { return true; }
+    static bool defaultIsSilent() { return false; }
 
     virtual CommandType type() const = 0;
     virtual bool equals(const AbstractCommand *other) const;
@@ -64,6 +64,7 @@ public:
     const QString description() const { return m_description; }
     const QString highlight() const { return m_highlight; }
     bool isSilent() const { return m_silent; }
+    CodeLocation codeLocation() const { return m_codeLocation; }
 
 protected:
     AbstractCommand();
@@ -72,6 +73,7 @@ private:
     QString m_description;
     QString m_highlight;
     bool m_silent;
+    CodeLocation m_codeLocation;
 };
 
 class ProcessCommand : public AbstractCommand