unmystify the serialization of artifacts

Move the serialization responsibility to Artifact itself.
Do not store parents. They are merely backpointers that can be restored
after loading.

Change-Id: I82b07f6ac07bd74b638985d86635894330743558
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

1 files changed, 10 insertions, 0 deletions

diff --git a/src/lib/buildgraph/artifact.cpp b/src/lib/buildgraph/artifact.cpp
index 28fd44dd9..9583f5f02 100644
--- a/src/lib/buildgraph/artifact.cpp
+++ b/src/lib/buildgraph/artifact.cpp
@@ -76,6 +76,13 @@ void Artifact::initialize()
 void Artifact::load(PersistentPool &pool)
 {
     FileResourceBase::load(pool);
+    pool.loadContainer(children);
+
+    // restore parents of the loaded children
+    for (ArtifactList::const_iterator it = children.constBegin(); it != children.constEnd(); ++it)
+        (*it)->parents.insert(this);
+
+    pool.loadContainer(fileDependencies);
     properties = pool.idLoadS<PropertyMapInternal>();
     transformer = pool.idLoadS<Transformer>();
     unsigned char c;
@@ -90,6 +97,9 @@ void Artifact::load(PersistentPool &pool)
 void Artifact::store(PersistentPool &pool) const
 {
     FileResourceBase::store(pool);
+    // Do not store parents to avoid recursion.
+    pool.storeContainer(children);
+    pool.storeContainer(fileDependencies);
     pool.store(properties);
     pool.store(transformer);
     pool.stream()