diff options
| author | Ivan Komissarov <abbapoh@gmail.com> | 2022-07-20 11:42:15 +0600 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2022-07-25 10:52:11 +0000 |
| commit | d78325aac8104daf4aa80ea4a76b53f6fbc0e0e5 (patch) | |
| tree | 2785793b04d84fdacaa9fd70ebb152ffcdd491db | |
| parent | faac35b5b3191348a72256437ccbb71a68dfb3a9 (diff) | |
| download | qbs-d78325aac8104daf4aa80ea4a76b53f6fbc0e0e5.tar.gz | |
Fix clang-tidy errors
Change-Id: Iec06eaf35b4ee23edb9f744b80b57db5115f3b4c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
| -rw-r--r-- | src/app/qbs-setup-toolchains/watcomprobe.cpp | 8 | ||||
| -rw-r--r-- | src/app/qbs-setup-toolchains/watcomprobe.h | 3 |
2 files changed, 6 insertions, 5 deletions
diff --git a/src/app/qbs-setup-toolchains/watcomprobe.cpp b/src/app/qbs-setup-toolchains/watcomprobe.cpp index dd60a21a5..13cb8d50c 100644 --- a/src/app/qbs-setup-toolchains/watcomprobe.cpp +++ b/src/app/qbs-setup-toolchains/watcomprobe.cpp @@ -115,7 +115,7 @@ static QStringList dumpOutput(const QFileInfo &compiler, QStringView flag, if (!flag.isEmpty()) args.push_back(flag.toString()); args.push_back(QDir::toNativeSeparators(filePath)); - p.start(compiler.absoluteFilePath(), std::move(args)); + p.start(compiler.absoluteFilePath(), args); p.waitForFinished(3000); fakeIn.remove(); const QStringList lines = QString::fromUtf8(p.readAllStandardOutput()) @@ -141,7 +141,7 @@ static bool supportsWatcomPlatform(const QFileInfo &compiler, const Platform &pl static std::vector<Profile> createWatcomProfileHelper(const ToolchainInstallInfo &info, Settings *settings, - const QString &profileName = QString()) + QStringView profileName = {}) { const QFileInfo compiler = info.compilerPath; std::vector<Profile> profiles; @@ -231,10 +231,10 @@ bool isWatcomCompiler(const QString &compilerName) }); } -void createWatcomProfile(const QFileInfo &compiler, Settings *settings, QString profileName) +void createWatcomProfile(const QFileInfo &compiler, Settings *settings, QStringView profileName) { const ToolchainInstallInfo info = {compiler, Version{}}; - createWatcomProfileHelper(info, settings, std::move(profileName)); + createWatcomProfileHelper(info, settings, profileName); } void watcomProbe(Settings *settings, std::vector<Profile> &profiles) diff --git a/src/app/qbs-setup-toolchains/watcomprobe.h b/src/app/qbs-setup-toolchains/watcomprobe.h index 26e75bbc3..ea010461d 100644 --- a/src/app/qbs-setup-toolchains/watcomprobe.h +++ b/src/app/qbs-setup-toolchains/watcomprobe.h @@ -52,7 +52,8 @@ class Settings; } // namespace qbs bool isWatcomCompiler(const QString &compilerName); -void createWatcomProfile(const QFileInfo &compiler, qbs::Settings *settings, QString profileName); +void createWatcomProfile( + const QFileInfo &compiler, qbs::Settings *settings, QStringView profileName); void watcomProbe(qbs::Settings *settings, std::vector<qbs::Profile> &profiles); #endif // Header guard |