summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason R. Coombs <jaraco@jaraco.com>2014-09-29 22:14:39 -0400
committerJason R. Coombs <jaraco@jaraco.com>2014-09-29 22:14:39 -0400
commitf11982fc00820b5daf0a2cb40c8e815ae701ad1f (patch)
tree287e8703c9c3faa7ebc46c2f588cb2980c744b2e
parent703f87fce1ff9370b642c91733ddbbf10899ab2a (diff)
downloadpython-setuptools-bitbucket-f11982fc00820b5daf0a2cb40c8e815ae701ad1f.tar.gz
Extract variable to be in proximity of its comment
-rw-r--r--setuptools/tests/environment.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/setuptools/tests/environment.py b/setuptools/tests/environment.py
index fa26a9ec..5fdbd969 100644
--- a/setuptools/tests/environment.py
+++ b/setuptools/tests/environment.py
@@ -96,10 +96,12 @@ def run_setup_py(cmd, pypath=None, path=None,
cmd = [sys.executable, "setup.py"] + list(cmd)
- #regarding the shell argument, see: http://bugs.python.org/issue8557
+ # http://bugs.python.org/issue8557
+ shell = sys.platform == 'win32'
+
try:
proc = _Popen(cmd, stdout=_PIPE, stderr=_PIPE,
- shell=(sys.platform == 'win32'), env=env)
+ shell=shell, env=env)
data = proc.communicate()[data_stream]
except OSError: