summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Cordasco <graffatcolmingov@gmail.com>2014-10-26 19:24:37 -0500
committerIan Cordasco <graffatcolmingov@gmail.com>2014-10-26 19:24:41 -0500
commitd505b94fa47dbce4eae4db09d0056b7808b71b01 (patch)
tree1c9b885b542cc38748507a61f6c563316ad6db78
parentbe805f942ea5286e4b6b5c899d96e8cb9e76e66c (diff)
downloadpython-requests-d505b94fa47dbce4eae4db09d0056b7808b71b01.tar.gz
Add DeprecationWarnings to inform users of plans
After a long discussion in IRC and on several issues, the developers of requests have decided to remove specific functions from requests.utils in version 3.0.0. To give users ample time to prepare for this, we've added DeprecationWarnings long in advance. See also the planning of this in issue #2266.
-rw-r--r--requests/utils.py11
1 files changed, 11 insertions, 0 deletions
diff --git a/requests/utils.py b/requests/utils.py
index 182348da..aa5c140e 100644
--- a/requests/utils.py
+++ b/requests/utils.py
@@ -19,6 +19,7 @@ import re
import sys
import socket
import struct
+import warnings
from . import __version__
from . import certs
@@ -287,6 +288,11 @@ def get_encodings_from_content(content):
:param content: bytestring to extract encodings from.
"""
+ warnings.warn((
+ 'In requests 3.0, get_encodings_from_content will be removed. For '
+ 'more information, please see the discussion on issue #2266. (This'
+ ' warning should only appear once.)'),
+ DeprecationWarning)
charset_re = re.compile(r'<meta.*?charset=["\']*(.+?)["\'>]', flags=re.I)
pragma_re = re.compile(r'<meta.*?content=["\']*;?charset=(.+?)["\'>]', flags=re.I)
@@ -354,6 +360,11 @@ def get_unicode_from_response(r):
2. fall back and replace all unicode characters
"""
+ warnings.warn((
+ 'In requests 3.0, get_unicode_from_response will be removed. For '
+ 'more information, please see the discussion on issue #2266. (This'
+ ' warning should only appear once.)'),
+ DeprecationWarning)
tried_encodings = []