summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Weißschuh <thomas@t-8ch.de>2014-09-25 19:47:56 +0000
committerThomas Weißschuh <thomas@t-8ch.de>2014-09-25 19:49:28 +0000
commit6e1db21733214e4d6707b0bc91b80499d4e946db (patch)
treefa4b0cb8f53278b1cc4ac28e2722841b1c404a41
parentde76fbeefbeae0974725e9470105347804d07349 (diff)
downloadpython-requests-6e1db21733214e4d6707b0bc91b80499d4e946db.tar.gz
fix #2247
We have to pass urllib3 the url without the authentication information, else it will be parsed by httplib as a netloc and included in the request line and Host header
-rw-r--r--requests/adapters.py4
-rw-r--r--requests/utils.py15
2 files changed, 17 insertions, 2 deletions
diff --git a/requests/adapters.py b/requests/adapters.py
index d17d9e69..8225d735 100644
--- a/requests/adapters.py
+++ b/requests/adapters.py
@@ -17,7 +17,7 @@ from .packages.urllib3.response import HTTPResponse
from .packages.urllib3.util import Timeout as TimeoutSauce
from .compat import urlparse, basestring, urldefrag
from .utils import (DEFAULT_CA_BUNDLE_PATH, get_encoding_from_headers,
- prepend_scheme_if_needed, get_auth_from_url)
+ prepend_scheme_if_needed, get_auth_from_url, urldefragauth)
from .structures import CaseInsensitiveDict
from .packages.urllib3.exceptions import ConnectTimeoutError
from .packages.urllib3.exceptions import HTTPError as _HTTPError
@@ -270,7 +270,7 @@ class HTTPAdapter(BaseAdapter):
proxy = proxies.get(scheme)
if proxy and scheme != 'https':
- url, _ = urldefrag(request.url)
+ url = urldefragauth(request.url)
else:
url = request.path_url
diff --git a/requests/utils.py b/requests/utils.py
index 539a68a0..44ab005d 100644
--- a/requests/utils.py
+++ b/requests/utils.py
@@ -672,3 +672,18 @@ def to_native_string(string, encoding='ascii'):
out = string.decode(encoding)
return out
+
+
+def urldefragauth(url):
+ """
+ Given a url remove the fragment and the authentication part
+ """
+ scheme, netloc, path, params, query, fragment = urlparse(url)
+
+ # see func:`prepend_scheme_if_needed`
+ if not netloc:
+ netloc, path = path, netloc
+
+ netloc = netloc.rsplit('@', 1)[-1]
+
+ return urlunparse((scheme, netloc, path, params, query, ''))