Merge pull request #206 from bdauvergne/button-value

Use empty string as default value for submit and button (#205)

2 files changed, 13 insertions, 2 deletions

diff --git a/tests/test_forms.py b/tests/test_forms.py
index af78ce5..e4668ae 100644
--- a/tests/test_forms.py
+++ b/tests/test_forms.py
@@ -40,6 +40,17 @@ class TestForms(unittest.TestCase):
         self.assertTrue(isinstance(button, Submit),
                         "<button> without type is a submit button")
 
+    def test_button_value_if_submitted(self):
+        form = self.callFUT()
+        submit = form['submit']
+        self.assertEqual(
+            submit.value_if_submitted(), '',
+            "submit default value is ''")
+        button = form['button']
+        self.assertEqual(
+            button.value_if_submitted(), '',
+            "submit default value is ''")
+
     def test_force_select(self):
         form = self.callFUT()
         form['select'].force_value('notavalue')
diff --git a/webtest/forms.py b/webtest/forms.py
index 6a330d8..72dfd8f 100644
--- a/webtest/forms.py
+++ b/webtest/forms.py
@@ -332,8 +332,8 @@ class Submit(Field):
     value = property(value__get, value__set)
 
     def value_if_submitted(self):
-        # TODO: does this ever get set?
-        return self._value
+        # parsed value of the empty string
+        return self._value or ''
 
 
 Field.classes['submit'] = Submit