Add cycle-breaking logic to create_connection()

This commit synchronizes create_connection() with the implementation in the socket module

1 files changed, 11 insertions, 6 deletions

diff --git a/src/urllib3/util/connection.py b/src/urllib3/util/connection.py
index 21ec8ecf..5f4be134 100644
--- a/src/urllib3/util/connection.py
+++ b/src/urllib3/util/connection.py
@@ -74,18 +74,23 @@ def create_connection(
             if source_address:
                 sock.bind(source_address)
             sock.connect(sa)
+            # Break explicitly a reference cycle
+            err = None
             return sock
 
-        except OSError as e:
-            err = e
+        except OSError as _:
+            err = _
             if sock is not None:
                 sock.close()
-                sock = None
 
     if err is not None:
-        raise err
-
-    raise OSError("getaddrinfo returns an empty list")
+        try:
+            raise err
+        finally:
+            # Break explicitly a reference cycle
+            err = None
+    else:
+        raise OSError("getaddrinfo returns an empty list")
 
 
 def _set_socket_options(sock: socket.socket, options: Optional[SocketOptions]) -> None: