diff options
| author | David Stanek <dstanek@dstanek.com> | 2015-10-05 18:23:35 +0000 |
|---|---|---|
| committer | David Stanek <dstanek@dstanek.com> | 2015-10-05 18:23:35 +0000 |
| commit | f8b7e6cce49c012885f9d15e05751c8dc85359e7 (patch) | |
| tree | 967717040a1c9524bf367528e17600819e9eef5e /tox/config.py | |
| parent | 260c83e398490f63791535b5df8b47d72b2ef42c (diff) | |
| download | tox-f8b7e6cce49c012885f9d15e05751c8dc85359e7.tar.gz | |
Fixes bug 181; allow # in commandsbug_181
If a # was in a command the original code naively removed it and
everything after assuming it was a comment. This meant that a #
could not be used in a command even if it was quoted or escaped.
This fix is backward incompatible because it no longer allows a
comment to appear after a line escape (\). I think is is acceptable
because in most other environments a backslash would preceed a
newline to escape it and tell the interpreter to ignore it. This
brings tox's command behavior more in line with what Unix shells
or Python actually do.
Diffstat (limited to 'tox/config.py')
| -rw-r--r-- | tox/config.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tox/config.py b/tox/config.py index d68d276..85f4650 100644 --- a/tox/config.py +++ b/tox/config.py @@ -999,9 +999,6 @@ class _ArgvlistReader: current_command = "" for line in value.splitlines(): line = line.rstrip() - i = line.find("#") - if i != -1: - line = line[:i].rstrip() if not line: continue if line.endswith("\\"): @@ -1053,7 +1050,6 @@ class _ArgvlistReader: shlexer = shlex.shlex(newcommand, posix=True) shlexer.whitespace_split = True shlexer.escape = '' - shlexer.commenters = '' argv = list(shlexer) return argv |