- new dialect for Drizzle [ticket:2003]

- move mysqldb to a connector, can be shared among mysql/drizzle

1 files changed, 21 insertions, 12 deletions

diff --git a/test/engine/test_reflection.py b/test/engine/test_reflection.py
index 8e7049b8f..e23633802 100644
--- a/test/engine/test_reflection.py
+++ b/test/engine/test_reflection.py
@@ -761,12 +761,13 @@ class ReflectionTest(TestBase, ComparesTables):
         finally:
             m1.drop_all()
 
+    @testing.requires.views
     @testing.provide_metadata
     def test_views(self):
         users, addresses = createTables(metadata, None)
         try:
             metadata.create_all()
-            createViews(metadata.bind, None)
+            _create_views(metadata.bind, None)
             m2 = MetaData(testing.db)
             users_v = Table("users_v", m2, autoload=True)
             addresses_v = Table("email_addresses_v", m2, autoload=True)
@@ -779,14 +780,15 @@ class ReflectionTest(TestBase, ComparesTables):
                 eq_(c1.name, c2.name)
                 self.assert_types_base(c1, c2)
         finally:
-            dropViews(metadata.bind)
+            _drop_views(metadata.bind)
 
+    @testing.requires.views
     @testing.provide_metadata
     def test_reflect_all_with_views(self):
         users, addresses = createTables(metadata, None)
         try:
             metadata.create_all()
-            createViews(metadata.bind, None)
+            _create_views(metadata.bind, None)
             m2 = MetaData(testing.db)
 
             m2.reflect(views=False)
@@ -803,7 +805,7 @@ class ReflectionTest(TestBase, ComparesTables):
                             u'users', u'email_addresses'])
             )
         finally:
-            dropViews(metadata.bind)
+            _drop_views(metadata.bind)
 
 class CreateDropTest(TestBase):
 
@@ -1108,7 +1110,8 @@ def createIndexes(con, schema=None):
     query = "CREATE INDEX users_t_idx ON %s (test1, test2)" % fullname
     con.execute(sa.sql.text(query))
 
-def createViews(con, schema=None):
+@testing.requires.views
+def _create_views(con, schema=None):
     for table_name in ('users', 'email_addresses'):
         fullname = table_name
         if schema:
@@ -1118,7 +1121,8 @@ def createViews(con, schema=None):
                                                                    fullname)
         con.execute(sa.sql.text(query))
 
-def dropViews(con, schema=None):
+@testing.requires.views
+def _drop_views(con, schema=None):
     for table_name in ('email_addresses', 'users'):
         fullname = table_name
         if schema:
@@ -1176,7 +1180,7 @@ class ComponentReflectionTest(TestBase):
         meta = MetaData(testing.db)
         (users, addresses) = createTables(meta, schema)
         meta.create_all()
-        createViews(meta.bind, schema)
+        _create_views(meta.bind, schema)
         try:
             insp = Inspector(meta.bind)
             if table_type == 'view':
@@ -1193,7 +1197,7 @@ class ComponentReflectionTest(TestBase):
                     answer = ['email_addresses', 'users']
             eq_(table_names, answer)
         finally:
-            dropViews(meta.bind, schema)
+            _drop_views(meta.bind, schema)
             addresses.drop()
             users.drop()
 
@@ -1204,6 +1208,7 @@ class ComponentReflectionTest(TestBase):
     def test_get_table_names_with_schema(self):
         self._test_get_table_names('test_schema')
 
+    @testing.requires.views
     def test_get_view_names(self):
         self._test_get_table_names(table_type='view')
 
@@ -1217,7 +1222,7 @@ class ComponentReflectionTest(TestBase):
         table_names = ['users', 'email_addresses']
         meta.create_all()
         if table_type == 'view':
-            createViews(meta.bind, schema)
+            _create_views(meta.bind, schema)
             table_names = ['users_v', 'email_addresses_v']
         try:
             insp = Inspector(meta.bind)
@@ -1258,7 +1263,7 @@ class ComponentReflectionTest(TestBase):
                                 col.type, cols[i]['name'], ctype))
         finally:
             if table_type == 'view':
-                dropViews(meta.bind, schema)
+                _drop_views(meta.bind, schema)
             addresses.drop()
             users.drop()
 
@@ -1269,9 +1274,11 @@ class ComponentReflectionTest(TestBase):
     def test_get_columns_with_schema(self):
         self._test_get_columns(schema='test_schema')
 
+    @testing.requires.views
     def test_get_view_columns(self):
         self._test_get_columns(table_type='view')
 
+    @testing.requires.views
     @testing.requires.schemas
     def test_get_view_columns_with_schema(self):
         self._test_get_columns(schema='test_schema', table_type='view')
@@ -1379,7 +1386,7 @@ class ComponentReflectionTest(TestBase):
         meta = MetaData(testing.db)
         (users, addresses) = createTables(meta, schema)
         meta.create_all()
-        createViews(meta.bind, schema)
+        _create_views(meta.bind, schema)
         view_name1 = 'users_v'
         view_name2 = 'email_addresses_v'
         try:
@@ -1389,13 +1396,15 @@ class ComponentReflectionTest(TestBase):
             v2 = insp.get_view_definition(view_name2, schema=schema)
             self.assert_(v2)
         finally:
-            dropViews(meta.bind, schema)
+            _drop_views(meta.bind, schema)
             addresses.drop()
             users.drop()
 
+    @testing.requires.views
     def test_get_view_definition(self):
         self._test_get_view_definition()
 
+    @testing.requires.views
     @testing.requires.schemas
     def test_get_view_definition_with_schema(self):
         self._test_get_view_definition(schema='test_schema')