summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy
diff options
context:
space:
mode:
authormike bayer <mike_mp@zzzcomputing.com>2020-05-15 15:14:55 +0000
committerGerrit Code Review <gerrit@bbpush.zzzcomputing.com>2020-05-15 15:14:55 +0000
commit0fe13a5fbe9b35255c119ec897347c66f06ca0d1 (patch)
tree2e2068774737e305dbaca9b60d3c281f9f7c1707 /lib/sqlalchemy
parent79de84b25e87bbb7fa94f0dd513b4abc76e05a7e (diff)
parentcc97dade0de008ce923dbb94db21a8e1ccb5bb22 (diff)
downloadsqlalchemy-0fe13a5fbe9b35255c119ec897347c66f06ca0d1.tar.gz
Merge "Move supports_sane_rowcount_returning = False to dialect level"
Diffstat (limited to 'lib/sqlalchemy')
-rw-r--r--lib/sqlalchemy/connectors/pyodbc.py3
-rw-r--r--lib/sqlalchemy/dialects/mssql/pyodbc.py3
2 files changed, 5 insertions, 1 deletions
diff --git a/lib/sqlalchemy/connectors/pyodbc.py b/lib/sqlalchemy/connectors/pyodbc.py
index d0c114822..cd79a3ada 100644
--- a/lib/sqlalchemy/connectors/pyodbc.py
+++ b/lib/sqlalchemy/connectors/pyodbc.py
@@ -14,7 +14,8 @@ from .. import util
class PyODBCConnector(Connector):
driver = "pyodbc"
- supports_sane_rowcount_returning = False
+ # this is no longer False for pyodbc in general
+ supports_sane_rowcount_returning = True
supports_sane_multi_rowcount = False
supports_unicode_statements = True
diff --git a/lib/sqlalchemy/dialects/mssql/pyodbc.py b/lib/sqlalchemy/dialects/mssql/pyodbc.py
index 5cb92ef07..ff164e886 100644
--- a/lib/sqlalchemy/dialects/mssql/pyodbc.py
+++ b/lib/sqlalchemy/dialects/mssql/pyodbc.py
@@ -314,6 +314,9 @@ class MSExecutionContext_pyodbc(MSExecutionContext):
class MSDialect_pyodbc(PyODBCConnector, MSDialect):
+ # mssql still has problems with this on Linux
+ supports_sane_rowcount_returning = False
+
execution_ctx_cls = MSExecutionContext_pyodbc
colspecs = util.update_copy(