diff options
| author | Heckad <heckad@yandex.ru> | 2020-01-01 14:47:01 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2020-01-03 13:09:46 -0500 |
| commit | a076b1f30406cbb59a55e2c01ddd17a84636778e (patch) | |
| tree | bb4c5a5b88d45963040842427d73f9616465bdb0 /lib/sqlalchemy/util/langhelpers.py | |
| parent | 748bf710fdeeed327933a5e7c277c7f79f6053a6 (diff) | |
| download | sqlalchemy-a076b1f30406cbb59a55e2c01ddd17a84636778e.tar.gz | |
Use context managers for threading.Lock()
(zzzeek:) For some reason I thought that threading.Lock() still did
not support context managers, at least in Python 2, however this
does not seem to be the case.
Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com>
Closes: #5069
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5069
Pull-request-sha: efeac06dda5afdbe33abcf9b27c8b5b5725c8444
Change-Id: Ic64fcd99cd587bc70b4ecc5b45d8205b5c76eff2
Diffstat (limited to 'lib/sqlalchemy/util/langhelpers.py')
| -rw-r--r-- | lib/sqlalchemy/util/langhelpers.py | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/lib/sqlalchemy/util/langhelpers.py b/lib/sqlalchemy/util/langhelpers.py index 83f119660..8124764be 100644 --- a/lib/sqlalchemy/util/langhelpers.py +++ b/lib/sqlalchemy/util/langhelpers.py @@ -1179,11 +1179,8 @@ def counter(): # avoid the 2to3 "next" transformation... def _next(): - lock.acquire() - try: + with lock: return next(counter) - finally: - lock.release() return _next @@ -1362,14 +1359,11 @@ class symbol(object): _lock = compat.threading.Lock() def __new__(cls, name, doc=None, canonical=None): - cls._lock.acquire() - try: + with cls._lock: sym = cls.symbols.get(name) if sym is None: cls.symbols[name] = sym = _symbol(name, doc, canonical) return sym - finally: - symbol._lock.release() @classmethod def parse_user_argument( |