summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/engine
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2013-05-26 18:23:26 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2013-05-26 18:23:26 -0400
commit61c796786cb222cfdca611395d8550973fc3f8d5 (patch)
treed635c3f6042a51d9b0b08448f8507afe0255b18f /lib/sqlalchemy/engine
parentebc03d5e63f41b51a5adf24b9c84978d09b74818 (diff)
downloadsqlalchemy-61c796786cb222cfdca611395d8550973fc3f8d5.tar.gz
do a sweep of some obvious 3kisms
Diffstat (limited to 'lib/sqlalchemy/engine')
-rw-r--r--lib/sqlalchemy/engine/reflection.py11
-rw-r--r--lib/sqlalchemy/engine/result.py2
-rw-r--r--lib/sqlalchemy/engine/url.py2
3 files changed, 6 insertions, 9 deletions
diff --git a/lib/sqlalchemy/engine/reflection.py b/lib/sqlalchemy/engine/reflection.py
index 4b2987851..cf2caf679 100644
--- a/lib/sqlalchemy/engine/reflection.py
+++ b/lib/sqlalchemy/engine/reflection.py
@@ -389,12 +389,11 @@ class Inspector(object):
del tblkw[k]
tblkw[str(k)] = v
-# start Py2K
-# if isinstance(schema, str):
-# schema = schema.decode(dialect.encoding)
-# if isinstance(table_name, str):
-# table_name = table_name.decode(dialect.encoding)
-# end Py2K
+ if util.py2k:
+ if isinstance(schema, str):
+ schema = schema.decode(dialect.encoding)
+ if isinstance(table_name, str):
+ table_name = table_name.decode(dialect.encoding)
# columns
found_table = False
diff --git a/lib/sqlalchemy/engine/result.py b/lib/sqlalchemy/engine/result.py
index 4261a5877..65ce3b742 100644
--- a/lib/sqlalchemy/engine/result.py
+++ b/lib/sqlalchemy/engine/result.py
@@ -215,8 +215,6 @@ class ResultMetaData(object):
processors.append(processor)
rec = (processor, obj, i)
-# name.encode('ascii')
-
# indexes as keys. This is only needed for the Python version of
# RowProxy (the C version uses a faster path for integer indexes).
primary_keymap[i] = rec
diff --git a/lib/sqlalchemy/engine/url.py b/lib/sqlalchemy/engine/url.py
index b7d56374e..ed5729eea 100644
--- a/lib/sqlalchemy/engine/url.py
+++ b/lib/sqlalchemy/engine/url.py
@@ -149,7 +149,7 @@ def make_url(name_or_url):
existing URL object is passed, just returns the object.
"""
- if isinstance(name_or_url, str):
+ if isinstance(name_or_url, util.string_types):
return _parse_rfc1738_args(name_or_url)
else:
return name_or_url