diff options
| author | Matthew Wilkes <git@matthewwilkes.name> | 2019-05-09 18:04:35 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-05-09 21:50:59 -0400 |
| commit | f601791a914d3181252493800871c458ad6c46d1 (patch) | |
| tree | 0833fca5a9b8e05ea6faf70d5a01ee1046190279 /lib/sqlalchemy/engine/default.py | |
| parent | 3abced7bd2842d41e17f438a65efc15aa71d4bb4 (diff) | |
| download | sqlalchemy-f601791a914d3181252493800871c458ad6c46d1.tar.gz | |
Move initialize do_rollback() outside of the dialect
Moved the "rollback" which occurs during dialect initialization so that it
occurs after additional dialect-specific initialize steps, in particular
those of the psycopg2 dialect which would inadvertently leave transactional
state on the first new connection, which could interfere with some
psycopg2-specific APIs which require that no transaction is started. Pull
request courtesy Matthew Wilkes.
Fixes: #4663
Closes: #4664
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/4664
Pull-request-sha: e544fe671d443ed06b210ba1cd1d7ba9c5653831
Change-Id: If40a15a1679b4eec0b8b8222f678697728009c30
Diffstat (limited to 'lib/sqlalchemy/engine/default.py')
| -rw-r--r-- | lib/sqlalchemy/engine/default.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/sqlalchemy/engine/default.py b/lib/sqlalchemy/engine/default.py index 51e2c4603..f6c30cbf4 100644 --- a/lib/sqlalchemy/engine/default.py +++ b/lib/sqlalchemy/engine/default.py @@ -312,8 +312,6 @@ class DefaultDialect(interfaces.Dialect): ): self._description_decoder = self.description_encoding = None - self.do_rollback(connection.connection) - def on_connect(self): """return a callable which sets up a newly created DBAPI connection. |