summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/databases
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2006-04-03 05:00:53 +0000
committerMike Bayer <mike_mp@zzzcomputing.com>2006-04-03 05:00:53 +0000
commitc8637ba660aec9f718e5e3d38a1c0c62983bbdb0 (patch)
tree9584ed3dfe16ab4437aef782e5dda8bf6b5d73f7 /lib/sqlalchemy/databases
parent29a6d142a99e8b1327fe11b2ad9263bb4a5bc32d (diff)
downloadsqlalchemy-c8637ba660aec9f718e5e3d38a1c0c62983bbdb0.tar.gz
made order_by/group_by construction a little more simplisitc
fix to mapper extension CompoundSelect can export all columns now, not sure if theres any advantage there
Diffstat (limited to 'lib/sqlalchemy/databases')
-rw-r--r--lib/sqlalchemy/databases/oracle.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/sqlalchemy/databases/oracle.py b/lib/sqlalchemy/databases/oracle.py
index 4736a2dda..c673cb961 100644
--- a/lib/sqlalchemy/databases/oracle.py
+++ b/lib/sqlalchemy/databases/oracle.py
@@ -276,9 +276,8 @@ class OracleCompiler(ansisql.ANSICompiler):
return
if select.limit is not None or select.offset is not None:
select._oracle_visit = True
- if hasattr(select, "order_by_clause"):
- orderby = self.strings[select.order_by_clause]
- else:
+ orderby = self.strings[select.order_by_clause]
+ if not orderby:
# to use ROW_NUMBER(), an ORDER BY is required. so here we dig in
# as best we can to find some column we can order by
# TODO: try to get "oid_column" to be used here