summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/connectors
diff options
context:
space:
mode:
authorDiana Clarke <diana.joan.clarke@gmail.com>2012-11-19 12:05:43 -0500
committerDiana Clarke <diana.joan.clarke@gmail.com>2012-11-19 12:05:43 -0500
commit0ac15d61f7a4b4b68cc4f1a63763823ee3c42d30 (patch)
treea13c5932e78213937ab7ddfae9b77dc9b3358794 /lib/sqlalchemy/connectors
parent6480e75a7c53db5fc31bbe87a1c68535caf61143 (diff)
downloadsqlalchemy-0ac15d61f7a4b4b68cc4f1a63763823ee3c42d30.tar.gz
just a pep8 pass of lib/sqlalchemy/connectors
Diffstat (limited to 'lib/sqlalchemy/connectors')
-rw-r--r--lib/sqlalchemy/connectors/__init__.py1
-rw-r--r--lib/sqlalchemy/connectors/mxodbc.py10
-rw-r--r--lib/sqlalchemy/connectors/mysqldb.py9
-rw-r--r--lib/sqlalchemy/connectors/pyodbc.py23
-rw-r--r--lib/sqlalchemy/connectors/zxJDBC.py1
5 files changed, 27 insertions, 17 deletions
diff --git a/lib/sqlalchemy/connectors/__init__.py b/lib/sqlalchemy/connectors/__init__.py
index 5a0e2eb24..97ac5232c 100644
--- a/lib/sqlalchemy/connectors/__init__.py
+++ b/lib/sqlalchemy/connectors/__init__.py
@@ -7,4 +7,3 @@
class Connector(object):
pass
-
diff --git a/lib/sqlalchemy/connectors/mxodbc.py b/lib/sqlalchemy/connectors/mxodbc.py
index d74e9639b..5f6fa8fc8 100644
--- a/lib/sqlalchemy/connectors/mxodbc.py
+++ b/lib/sqlalchemy/connectors/mxodbc.py
@@ -24,8 +24,9 @@ import warnings
from . import Connector
+
class MxODBCConnector(Connector):
- driver='mxodbc'
+ driver = 'mxodbc'
supports_sane_multi_rowcount = False
supports_unicode_statements = True
@@ -47,7 +48,7 @@ class MxODBCConnector(Connector):
elif platform == 'darwin':
from mx.ODBC import iODBC as module
else:
- raise ImportError, "Unrecognized platform for mxODBC import"
+ raise ImportError("Unrecognized platform for mxODBC import")
return module
@classmethod
@@ -73,8 +74,8 @@ class MxODBCConnector(Connector):
emit Python standard warnings.
"""
from mx.ODBC.Error import Warning as MxOdbcWarning
- def error_handler(connection, cursor, errorclass, errorvalue):
+ def error_handler(connection, cursor, errorclass, errorvalue):
if issubclass(errorclass, MxOdbcWarning):
errorclass.__bases__ = (Warning,)
warnings.warn(message=str(errorvalue),
@@ -141,7 +142,8 @@ class MxODBCConnector(Connector):
return True
def do_executemany(self, cursor, statement, parameters, context=None):
- cursor.executemany(statement, parameters, direct=self._get_direct(context))
+ cursor.executemany(
+ statement, parameters, direct=self._get_direct(context))
def do_execute(self, cursor, statement, parameters, context=None):
cursor.execute(statement, parameters, direct=self._get_direct(context))
diff --git a/lib/sqlalchemy/connectors/mysqldb.py b/lib/sqlalchemy/connectors/mysqldb.py
index 4479deafe..5f4b3e4d3 100644
--- a/lib/sqlalchemy/connectors/mysqldb.py
+++ b/lib/sqlalchemy/connectors/mysqldb.py
@@ -10,9 +10,11 @@ from ..sql import operators as sql_operators
from .. import exc, log, schema, sql, types as sqltypes, util, processors
import re
+
# the subclassing of Connector by all classes
# here is not strictly necessary
+
class MySQLDBExecutionContext(Connector):
@property
@@ -22,6 +24,7 @@ class MySQLDBExecutionContext(Connector):
else:
return self.cursor.rowcount
+
class MySQLDBCompiler(Connector):
def visit_mod_binary(self, binary, operator, **kw):
return self.process(binary.left, **kw) + " %% " + \
@@ -30,12 +33,14 @@ class MySQLDBCompiler(Connector):
def post_process_text(self, text):
return text.replace('%', '%%')
+
class MySQLDBIdentifierPreparer(Connector):
def _escape_identifier(self, value):
value = value.replace(self.escape_quote, self.escape_to_quote)
return value.replace("%", "%%")
+
class MySQLDBConnector(Connector):
driver = 'mysqldb'
supports_unicode_statements = False
@@ -76,7 +81,8 @@ class MySQLDBConnector(Connector):
# query string.
ssl = {}
- for key in ['ssl_ca', 'ssl_key', 'ssl_cert', 'ssl_capath', 'ssl_cipher']:
+ keys = ['ssl_ca', 'ssl_key', 'ssl_cert', 'ssl_capath', 'ssl_cipher']
+ for key in keys:
if key in opts:
ssl[key[4:]] = opts[key]
util.coerce_kw_type(ssl, key[4:], str)
@@ -148,4 +154,3 @@ class MySQLDBConnector(Connector):
"combination of MySQL server and MySQL-python. "
"MySQL-python >= 1.2.2 is recommended. Assuming latin1.")
return 'latin1'
-
diff --git a/lib/sqlalchemy/connectors/pyodbc.py b/lib/sqlalchemy/connectors/pyodbc.py
index 7ef0922cf..678d50f4c 100644
--- a/lib/sqlalchemy/connectors/pyodbc.py
+++ b/lib/sqlalchemy/connectors/pyodbc.py
@@ -11,8 +11,9 @@ import sys
import re
import urllib
+
class PyODBCConnector(Connector):
- driver='pyodbc'
+ driver = 'pyodbc'
supports_sane_multi_rowcount = False
# PyODBC unicode is broken on UCS-4 builds
@@ -63,7 +64,7 @@ class PyODBCConnector(Connector):
dsn_connection = 'dsn' in keys or \
('host' in keys and 'database' not in keys)
if dsn_connection:
- connectors= ['dsn=%s' % (keys.pop('host', '') or \
+ connectors = ['dsn=%s' % (keys.pop('host', '') or \
keys.pop('dsn', ''))]
else:
port = ''
@@ -73,7 +74,7 @@ class PyODBCConnector(Connector):
connectors = ["DRIVER={%s}" %
keys.pop('driver', self.pyodbc_driver_name),
'Server=%s%s' % (keys.pop('host', ''), port),
- 'Database=%s' % keys.pop('database', '') ]
+ 'Database=%s' % keys.pop('database', '')]
user = keys.pop("user", None)
if user:
@@ -90,8 +91,8 @@ class PyODBCConnector(Connector):
connectors.append("AutoTranslate=%s" %
keys.pop("odbc_autotranslate"))
- connectors.extend(['%s=%s' % (k,v) for k,v in keys.iteritems()])
- return [[";".join (connectors)], connect_args]
+ connectors.extend(['%s=%s' % (k, v) for k, v in keys.iteritems()])
+ return [[";".join(connectors)], connect_args]
def is_disconnect(self, e, connection, cursor):
if isinstance(e, self.dbapi.ProgrammingError):
@@ -117,18 +118,20 @@ class PyODBCConnector(Connector):
))
if self.freetds:
- self.freetds_driver_version = dbapi_con.getinfo(pyodbc.SQL_DRIVER_VER)
+ self.freetds_driver_version = dbapi_con.getinfo(
+ pyodbc.SQL_DRIVER_VER)
# the "Py2K only" part here is theoretical.
# have not tried pyodbc + python3.1 yet.
# Py2K
- self.supports_unicode_statements = not self.freetds and not self.easysoft
+ self.supports_unicode_statements = (
+ not self.freetds and not self.easysoft)
if self._user_supports_unicode_binds is not None:
self.supports_unicode_binds = self._user_supports_unicode_binds
else:
- self.supports_unicode_binds = (not self.freetds or
- self.freetds_driver_version >= '0.91'
- ) and not self.easysoft
+ self.supports_unicode_binds = (
+ not self.freetds or self.freetds_driver_version >= '0.91'
+ ) and not self.easysoft
# end Py2K
# run other initialization which asks for user name, etc.
diff --git a/lib/sqlalchemy/connectors/zxJDBC.py b/lib/sqlalchemy/connectors/zxJDBC.py
index 1db7a619d..433e02745 100644
--- a/lib/sqlalchemy/connectors/zxJDBC.py
+++ b/lib/sqlalchemy/connectors/zxJDBC.py
@@ -7,6 +7,7 @@
import sys
from . import Connector
+
class ZxJDBCConnector(Connector):
driver = 'zxjdbc'