diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2013-06-03 16:32:12 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2013-06-03 16:32:12 -0400 |
| commit | d993bdeac8674db88efb3c400b4a505c8f97af9e (patch) | |
| tree | dafd15d9e15bf6068a4f76a91bbaafac6ddde785 /doc | |
| parent | f8325d9dbb52d0da140f3403ce915645ae4a5a9c (diff) | |
| download | sqlalchemy-d993bdeac8674db88efb3c400b4a505c8f97af9e.tar.gz | |
- remove the ``__iter__()`` with notimplemented since it interferes
with legitimate iterable detection, [ticket:2726]
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/build/changelog/changelog_08.rst | 15 | ||||
| -rw-r--r-- | doc/build/changelog/changelog_09.rst | 15 |
2 files changed, 30 insertions, 0 deletions
diff --git a/doc/build/changelog/changelog_08.rst b/doc/build/changelog/changelog_08.rst index 211668867..7e8e618a4 100644 --- a/doc/build/changelog/changelog_08.rst +++ b/doc/build/changelog/changelog_08.rst @@ -7,6 +7,21 @@ :version: 0.8.2 .. change:: + :tags: bug, sql + :tickets: 2726 + + Removed the "not implemented" ``__iter__()`` call from the base + :class:`.ColumnOperators` class, while this was introduced + in 0.8.0 to prevent an endless, memory-growing loop when one also + implements a ``__getitem__()`` method on a custom + operator and then calls erroneously ``list()`` on that object, + it had the effect of causing column elements to report that they + were in fact iterable types which then throw an error when you try + to iterate. There's no real way to have both sides here so we + stick with Python best practices. Careful with implementing + ``__getitem__()`` on your custom operators! + + .. change:: :tags: feature, orm :tickets: 2736 diff --git a/doc/build/changelog/changelog_09.rst b/doc/build/changelog/changelog_09.rst index df87f397c..3c9682105 100644 --- a/doc/build/changelog/changelog_09.rst +++ b/doc/build/changelog/changelog_09.rst @@ -7,6 +7,21 @@ :version: 0.9.0 .. change:: + :tags: bug, sql + :tickets: 2726 + + Removed the "not implemented" ``__iter__()`` call from the base + :class:`.ColumnOperators` class, while this was introduced + in 0.8.0 to prevent an endless, memory-growing loop when one also + implements a ``__getitem__()`` method on a custom + operator and then calls erroneously ``list()`` on that object, + it had the effect of causing column elements to report that they + were in fact iterable types which then throw an error when you try + to iterate. There's no real way to have both sides here so we + stick with Python best practices. Careful with implementing + ``__getitem__()`` on your custom operators! Also in 0.8.2. + + .. change:: :tags: feature, sql :tickets: 1068 |