summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVladimir Magamedov <vladimir@magamedov.com>2013-09-04 11:43:40 +0300
committerVladimir Magamedov <vladimir@magamedov.com>2013-09-04 11:50:16 +0300
commitd471b9041a1c4202dfae808e9f8cbbbebd8dc580 (patch)
treeed17798ba66c9a3b1d3039854458c4f8fd692bec
parentb727d05ce1d23289878899b8982aeba09b824d62 (diff)
downloadsqlalchemy-pr/24.tar.gz
Fixed Query.exists() method for the case, when query doesn't have any filters applied.pr/24
-rw-r--r--lib/sqlalchemy/orm/query.py2
-rw-r--r--test/orm/test_query.py11
2 files changed, 11 insertions, 2 deletions
diff --git a/lib/sqlalchemy/orm/query.py b/lib/sqlalchemy/orm/query.py
index b71bfe08f..d64575aec 100644
--- a/lib/sqlalchemy/orm/query.py
+++ b/lib/sqlalchemy/orm/query.py
@@ -2494,7 +2494,7 @@ class Query(object):
.. versionadded:: 0.8.1
"""
- return sql.exists(self.with_entities('1').statement)
+ return sql.exists(self.statement.with_only_columns(['1']))
def count(self):
"""Return a count of rows this Query would return.
diff --git a/test/orm/test_query.py b/test/orm/test_query.py
index 0973dc357..7151ef0b6 100644
--- a/test/orm/test_query.py
+++ b/test/orm/test_query.py
@@ -1730,9 +1730,18 @@ class ExistsTest(QueryTest, AssertsCompiledSQL):
def test_exists(self):
User = self.classes.User
sess = create_session()
- q1 = sess.query(User).filter(User.name == 'fred')
+
+ q1 = sess.query(User)
self.assert_compile(sess.query(q1.exists()),
'SELECT EXISTS ('
+ 'SELECT 1 FROM users'
+ ') AS anon_1',
+ dialect=default.DefaultDialect()
+ )
+
+ q2 = sess.query(User).filter(User.name == 'fred')
+ self.assert_compile(sess.query(q2.exists()),
+ 'SELECT EXISTS ('
'SELECT 1 FROM users WHERE users.name = :name_1'
') AS anon_1',
dialect=default.DefaultDialect()