summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2014-12-04 19:45:14 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2014-12-04 19:45:14 -0500
commit60174146410d4ce2a17faa76cd981f558490db92 (patch)
tree363e8e070377aadc210508ebd15c5fa78a494594
parente46c71b4198ee9811ea851dbe037f19a74af0b08 (diff)
downloadsqlalchemy-60174146410d4ce2a17faa76cd981f558490db92.tar.gz
- the refactor of the visit_alias() method in Oracle revealed
that quoting should be applied in %(name)s under with_hint.
-rw-r--r--doc/build/changelog/changelog_10.rst7
-rw-r--r--test/sql/test_compiler.py2
2 files changed, 8 insertions, 1 deletions
diff --git a/doc/build/changelog/changelog_10.rst b/doc/build/changelog/changelog_10.rst
index 32fe4daab..0256958b2 100644
--- a/doc/build/changelog/changelog_10.rst
+++ b/doc/build/changelog/changelog_10.rst
@@ -23,6 +23,13 @@
on compatibility concerns, see :doc:`/changelog/migration_10`.
.. change::
+ :tags: bug, oracle
+
+ An alias name will be properly quoted when referred to using the
+ ``%(name)s`` token inside the :meth:`.Select.with_hint` method.
+ Previously, the Oracle backend hadn't implemented this quoting.
+
+ .. change::
:tags: feature, oracle
:tickets: 3220
diff --git a/test/sql/test_compiler.py b/test/sql/test_compiler.py
index 9e99a947b..428fc8986 100644
--- a/test/sql/test_compiler.py
+++ b/test/sql/test_compiler.py
@@ -2440,7 +2440,7 @@ class SelectTest(fixtures.TestBase, AssertsCompiledSQL):
"""SELECT /*+ "QuotedName" idx1 */ "QuotedName".col1 """
"""FROM "QuotedName" WHERE "QuotedName".col1 > :col1_1"""),
(s7, oracle_d,
- """SELECT /*+ SomeName idx1 */ "SomeName".col1 FROM """
+ """SELECT /*+ "SomeName" idx1 */ "SomeName".col1 FROM """
""""QuotedName" "SomeName" WHERE "SomeName".col1 > :col1_1"""),
]:
self.assert_compile(