summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2019-01-24 12:41:51 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2019-01-24 12:41:51 -0500
commita11a5f5af6b0c76d6f07a7ed3dd8eff7dda95ed6 (patch)
treee5e13bfbef76936016aeb1b06ed6ece8210f47c0
parent78e598e3a5b8df7419a600c291f90260e598c9b7 (diff)
downloadsqlalchemy-a11a5f5af6b0c76d6f07a7ed3dd8eff7dda95ed6.tar.gz
- all the checkboxes are just embarassing, just do something simple
Change-Id: Icb689ffbc780016ec59c549c65e6add20c96951e
-rw-r--r--.github/pull_request_template.md24
1 files changed, 9 insertions, 15 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 22c904f7d..01bdac9c9 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -13,21 +13,15 @@ This pull request is:
- [ ] A documentation / typographical error fix
- Good to go, no issue or tests are needed
- [ ] A short code fix
- - [ ] There is a bug report already, or I have filed [a bug report](https://github.com/sqlalchemy/sqlalchemy/issues) which includes a test case ([MCVE](http://stackoverflow.com/help/mcve)) illustrating in simple code form the expected behavior and how the library deviates from it.
- - [ ] My git commit includes a `Fixes: #<issue number>` comment with the above bug report number
- - [ ] My code fix includes a unit test, which is typically based on the MCVE I did above
- - [ ] I then **ran the tests**, using the instructions at [README.unittests.rst](https://github.com/sqlalchemy/sqlalchemy/blob/master/README.unittests.rst)
- - [ ] I don't know how to write a test for this. In which case please FILE A BUG ONLY.
- - [ ] I will be able to respond in a timely fashion to additional requests for changes and detail.
+ - please include the issue number, and create an issue if none exists, which
+ must include a complete example of the issue. one line code fixes without an
+ issue and demonstration will not be accepted.
+ - Please include: `Fixes: #<issue number>` in the commit message
+ - please include tests. one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- - [ ] There is a bug report already, or I have filed [a bug report](https://github.com/sqlalchemy/sqlalchemy/issues) which includes a complete description of the new behavior, including an a Python code example that illustrates how the feature would work.
- - [ ] The new feature request was **approved by SQLAlchemy maintainers** who requested that I submit a pull request.
- - [ ] My git commit includes a `Fixes: #<issue number>` comment with the above bug report number
- - [ ] My code fix includes unit tests that assert the behavior is as expected.
- - [ ] I then **ran the tests**, using the instructions at [README.unittests.rst](https://github.com/sqlalchemy/sqlalchemy/blob/master/README.unittests.rst)
- - [ ] I don't know how to write the tests. in which case please GET HELP FROM THE MAINTAINERS on the above mentioned issue how tests for this feature should be structured.
- - [ ] I will be able to respond in a timely fashion to additional requests for changes and detail.
-
-<!-- Note that **we do not accept one-liner code fix pull requests with no tests**. Code that is not tested is itself **a bug**. We will help you fix any problem you have, as long as you produce [issue reports](https://github.com/sqlalchemy/sqlalchemy/issues) that include code samples, stack traces, and most preferably complete standalone test cases. -->
+ - please include the issue number, and create an issue if none exists, which must
+ include a complete example of how the feature would look.
+ - Please include: `Fixes: #<issue number>` in the commit message
+ - please include tests.
**Have a nice day!**