summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Kirtland <jek@discorporate.us>2007-06-16 22:04:13 +0000
committerJason Kirtland <jek@discorporate.us>2007-06-16 22:04:13 +0000
commit6cd584d3031bbb810d2c7f400ae38b941088ded9 (patch)
treee4ec73ea79d4fabed09e60dba421b3f1617ee46c
parent84420a1d0fe09d7a45e878e853aa9f5258561f8b (diff)
downloadsqlalchemy-6cd584d3031bbb810d2c7f400ae38b941088ded9.tar.gz
- Fixed typo blocking some assoc proxy dict assignments, added test
-rw-r--r--lib/sqlalchemy/ext/associationproxy.py2
-rw-r--r--test/ext/associationproxy.py3
2 files changed, 4 insertions, 1 deletions
diff --git a/lib/sqlalchemy/ext/associationproxy.py b/lib/sqlalchemy/ext/associationproxy.py
index 1b363c9ac..cdb814702 100644
--- a/lib/sqlalchemy/ext/associationproxy.py
+++ b/lib/sqlalchemy/ext/associationproxy.py
@@ -189,7 +189,7 @@ class AssociationProxy(object):
return _AssociationList(lazy_collection, creator, getter, setter)
elif self.collection_class is dict:
kv_setter = lambda o, k, v: setattr(o, value_attr, v)
- return _AssociationDict(lazy_collection, creator, getter, setter)
+ return _AssociationDict(lazy_collection, creator, getter, kv_setter)
elif self.collection_class is util.Set:
return _AssociationSet(lazy_collection, creator, getter, setter)
else:
diff --git a/test/ext/associationproxy.py b/test/ext/associationproxy.py
index e095d285e..4935f4b6e 100644
--- a/test/ext/associationproxy.py
+++ b/test/ext/associationproxy.py
@@ -218,6 +218,9 @@ class CustomDictTest(DictTest):
self.assert_(len(p1._children) == 3)
self.assert_(len(p1.children) == 3)
+ p1.children['d'] = 'new d'
+ assert p1.children['d'] == 'new d'
+
p1._children = {}
self.assert_(len(p1.children) == 0)