diff options
| author | Andy Grover <agrover@redhat.com> | 2014-05-05 12:08:57 -0700 |
|---|---|---|
| committer | Andy Grover <agrover@redhat.com> | 2014-05-05 12:08:57 -0700 |
| commit | b0c41a578bb43db1e787106c2dbc2b46465476a5 (patch) | |
| tree | 593d31bc64c869ca309a1c6028af467bee77b4f1 | |
| parent | 3275ad59d471bd8c5cd9e29335a82b01dbc9abfa (diff) | |
| download | rtslib-fb-b0c41a578bb43db1e787106c2dbc2b46465476a5.tar.gz | |
Do not set emulate_write_cache based on write_back param for block
Since the kernel's d0c8b259f (in 3.9+), setting emulate_write_cache for
block backstores has not done anything -- the kernel now actually uses
the queue's REQ_FLUSH flag.
No longer set this attribute, but keep the parameter for backwards
compatibility.
Signed-off-by: Andy Grover <agrover@redhat.com>
| -rw-r--r-- | rtslib/tcm.py | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/rtslib/tcm.py b/rtslib/tcm.py index 377f576..b370ce5 100644 --- a/rtslib/tcm.py +++ b/rtslib/tcm.py @@ -671,14 +671,14 @@ class BlockStorageObject(StorageObject): if dev is not None: super(BlockStorageObject, self).__init__(name, 'create') try: - self._configure(dev, wwn, readonly, write_back) + self._configure(dev, wwn, readonly) except: self.delete() raise else: super(BlockStorageObject, self).__init__(name, 'lookup') - def _configure(self, dev, wwn, readonly, write_back): + def _configure(self, dev, wwn, readonly): self._check_self() if get_blockdev_type(dev) != 0: raise RTSLibError("Device is not a TYPE_DISK block device.") @@ -690,9 +690,6 @@ class BlockStorageObject(StorageObject): self._control("readonly=%d" % readonly) self._enable() - if write_back: - self.set_attribute("emulate_write_cache", 1) - super(BlockStorageObject, self)._configure(wwn) def _get_major(self): |