diff options
author | Bar Shaul <88437685+barshaul@users.noreply.github.com> | 2022-06-27 13:28:09 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-06-27 13:28:09 +0300 |
commit | 11cf66afc9b764248f12761138cc28a2b3e1366c (patch) | |
tree | 14bf8bd455faeb3f98f16b5eece8e2abd12d6f3b | |
parent | 8b18d5b2b63ebf218a1f116367a1a09c3d402192 (diff) | |
download | redis-py-11cf66afc9b764248f12761138cc28a2b3e1366c.tar.gz |
Changed dynamic_startup_nodes default value to 'True' to prevent breaking backward compatibility (#2251)
-rw-r--r-- | README.md | 4 | ||||
-rw-r--r-- | redis/cluster.py | 10 |
2 files changed, 7 insertions, 7 deletions
@@ -1268,7 +1268,7 @@ Using scripting within pipelines in cluster mode is **not supported**. When set to true, read commands will be assigned between the primary and its replications in a Round-Robin manner. - dynamic_startup_nodes: (default=False) + dynamic_startup_nodes: (default=True) Set the RedisCluster's startup nodes to all of the discovered nodes. If true, the cluster's discovered nodes will be used to determine the @@ -1276,7 +1276,7 @@ Using scripting within pipelines in cluster mode is **not supported**. It will remove the initial passed startup nodes if their endpoints aren't listed in the CLUSTER SLOTS output. If you use dynamic DNS endpoints for startup nodes but CLUSTER SLOTS lists - specific IP addresses, keep it at false. + specific IP addresses, it is best to set it to false. cluster_error_retry_attempts: (default=3) diff --git a/redis/cluster.py b/redis/cluster.py index c5b6c8d..b301cdc 100644 --- a/redis/cluster.py +++ b/redis/cluster.py @@ -482,7 +482,7 @@ class RedisCluster(AbstractRedisCluster, RedisClusterCommands): require_full_coverage=False, reinitialize_steps=10, read_from_replicas=False, - dynamic_startup_nodes=False, + dynamic_startup_nodes=True, url=None, **kwargs, ): @@ -512,12 +512,12 @@ class RedisCluster(AbstractRedisCluster, RedisClusterCommands): primary and its replications in a Round-Robin manner. :dynamic_startup_nodes: 'bool' Set the RedisCluster's startup nodes to all of the discovered nodes. - If true, the cluster's discovered nodes will be used to determine the - cluster nodes-slots mapping in the next topology refresh. + If true (default value), the cluster's discovered nodes will be used to + determine the cluster nodes-slots mapping in the next topology refresh. It will remove the initial passed startup nodes if their endpoints aren't listed in the CLUSTER SLOTS output. If you use dynamic DNS endpoints for startup nodes but CLUSTER SLOTS lists - specific IP addresses, keep it at false. + specific IP addresses, it is best to set it to false. :cluster_error_retry_attempts: 'int' Retry command execution attempts when encountering ClusterDownError or ConnectionError @@ -1293,7 +1293,7 @@ class NodesManager: from_url=False, require_full_coverage=False, lock=None, - dynamic_startup_nodes=False, + dynamic_startup_nodes=True, **kwargs, ): self.nodes_cache = {} |