diff options
| author | Robert Godfrey <rgodfrey@apache.org> | 2012-11-26 10:48:38 +0000 |
|---|---|---|
| committer | Robert Godfrey <rgodfrey@apache.org> | 2012-11-26 10:48:38 +0000 |
| commit | 0639f931d3a7cf0aa3c0834ed3bfe670dc9b582d (patch) | |
| tree | 0d5900125666765eb7cf4a5de108f1ed87096992 /java/common | |
| parent | 92626b52ee79478f045dd3308b1c5087095d3d79 (diff) | |
| download | qpid-python-0639f931d3a7cf0aa3c0834ed3bfe670dc9b582d.tar.gz | |
QPID-2796 : Addressed review comments
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1413549 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'java/common')
3 files changed, 10 insertions, 6 deletions
diff --git a/java/common/src/main/java/org/apache/qpid/transport/Connection.java b/java/common/src/main/java/org/apache/qpid/transport/Connection.java index 3bff9aa346..5ae2f1ceb2 100644 --- a/java/common/src/main/java/org/apache/qpid/transport/Connection.java +++ b/java/common/src/main/java/org/apache/qpid/transport/Connection.java @@ -229,7 +229,7 @@ public class Connection extends ConnectionInvoker addConnectionListener((ConnectionListener)secureReceiver); } - NetworkConnection network = transport.connect(settings, secureReceiver, null); + NetworkConnection network = transport.connect(settings, secureReceiver, new ConnectionActivity()); setRemoteAddress(network.getRemoteAddress()); setLocalAddress(network.getLocalAddress()); diff --git a/java/common/src/main/java/org/apache/qpid/transport/network/io/IdleTimeoutTicker.java b/java/common/src/main/java/org/apache/qpid/transport/network/io/IdleTimeoutTicker.java index b8a8d42c7c..54a2a360bb 100644 --- a/java/common/src/main/java/org/apache/qpid/transport/network/io/IdleTimeoutTicker.java +++ b/java/common/src/main/java/org/apache/qpid/transport/network/io/IdleTimeoutTicker.java @@ -43,14 +43,14 @@ class IdleTimeoutTicker implements Ticker long nextTime = -1; final long maxReadIdle = 1000l * _connection.getMaxReadIdle(); - if(maxReadIdle != 0) + if(maxReadIdle > 0) { nextTime = _transport.getLastReadTime() + maxReadIdle; } long maxWriteIdle = 1000l * _connection.getMaxWriteIdle(); - if(maxWriteIdle != 0) + if(maxWriteIdle > 0) { long writeTime = _transport.getLastWriteTime() + maxWriteIdle; if(nextTime == -1l || writeTime < nextTime) @@ -66,13 +66,13 @@ class IdleTimeoutTicker implements Ticker { // writer Idle long maxWriteIdle = 1000l * _connection.getMaxWriteIdle(); - if(maxWriteIdle != 0 && maxWriteIdle+ _transport.getLastWriteTime() <= currentTime) + if(maxWriteIdle > 0 && maxWriteIdle+ _transport.getLastWriteTime() <= currentTime) { _transport.writerIdle(); } // reader Idle final long maxReadIdle = 1000l * _connection.getMaxReadIdle(); - if(maxReadIdle != 0 && maxReadIdle+ _transport.getLastReadTime() <= currentTime) + if(maxReadIdle > 0 && maxReadIdle+ _transport.getLastReadTime() <= currentTime) { _transport.readerIdle(); diff --git a/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java b/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java index 11f28a2aee..06a43e21c6 100644 --- a/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java +++ b/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java @@ -170,7 +170,11 @@ final class IoReceiver implements Runnable, Closeable if(_ticker != null) { - final int tick = _ticker.getTimeToNextTick(currentTime); + int tick = _ticker.getTimeToNextTick(currentTime); + if(tick <= 0) + { + tick = _ticker.tick(currentTime); + } try { if(!socket.isClosed()) |