summaryrefslogtreecommitdiff
path: root/pymemcache
diff options
context:
space:
mode:
authorNick Pope <nick.pope@flightdataservices.com>2020-08-17 23:05:21 +0100
committerNick Pope <nick.pope@flightdataservices.com>2020-08-17 23:35:58 +0100
commit27b5b04c070c00d95860e6e50235cfeb6693cdff (patch)
tree7ff78d097c1ebe229cb5cc80b8886da01ee702d7 /pymemcache
parentf3bc1e07161fd451c4aa94790e3db7bf1b71a89e (diff)
downloadpymemcache-27b5b04c070c00d95860e6e50235cfeb6693cdff.tar.gz
Stopped storing False for missing keys in HashClient.get_many().
Storing False when the client doesn't exist can be confused with False being stored as the actual value. This behavior only occurred when using ignore_exc=True. Fixes #291.
Diffstat (limited to 'pymemcache')
-rw-r--r--pymemcache/client/hash.py1
-rw-r--r--pymemcache/test/test_client_hash.py2
2 files changed, 1 insertions, 2 deletions
diff --git a/pymemcache/client/hash.py b/pymemcache/client/hash.py
index 9c537d3..536b915 100644
--- a/pymemcache/client/hash.py
+++ b/pymemcache/client/hash.py
@@ -377,7 +377,6 @@ class HashClient(object):
client = self._get_client(key)
if client is None:
- end[key] = False
continue
client_batches[client.server].append(key)
diff --git a/pymemcache/test/test_client_hash.py b/pymemcache/test/test_client_hash.py
index c5f3c4b..322ce3d 100644
--- a/pymemcache/test/test_client_hash.py
+++ b/pymemcache/test/test_client_hash.py
@@ -241,7 +241,7 @@ class TestHashClient(ClientTestMixin, unittest.TestCase):
)
result = client.get_many(['foo', 'bar'])
- assert result == {'foo': False, 'bar': False}
+ assert result == {}
def test_ignore_exec_set_many(self):
values = {