diff options
author | Claudiu Popa <cpopa@cloudbasesolutions.com> | 2015-03-11 17:24:01 +0200 |
---|---|---|
committer | Claudiu Popa <cpopa@cloudbasesolutions.com> | 2015-03-11 17:24:01 +0200 |
commit | 407d2ab9ea9516ea190733a7542ddf57ed89fb8f (patch) | |
tree | d0e8ec39f7b26f6a7e114d12736ecac0831ce9cc | |
parent | f57dae9a1134df95e6418f37f6b7bf5ced1c77b0 (diff) | |
download | pylint-407d2ab9ea9516ea190733a7542ddf57ed89fb8f.tar.gz |
Remove abstract-class-little-used warning, since it doesn't add any real value.
-rw-r--r-- | pylint/checkers/design_analysis.py | 10 | ||||
-rw-r--r-- | pylint/test/functional/abstract_abc_methods.py | 2 | ||||
-rw-r--r-- | pylint/test/functional/abstract_class_instantiated_py2.py | 2 | ||||
-rw-r--r-- | pylint/test/functional/abstract_class_instantiated_py3.py | 2 | ||||
-rw-r--r-- | pylint/test/functional/abstract_method_py2.py | 2 | ||||
-rw-r--r-- | pylint/test/functional/abstract_method_py3.py | 2 | ||||
-rw-r--r-- | pylint/test/input/func_method_could_be_function.py | 2 | ||||
-rw-r--r-- | pylint/test/input/func_noerror_classes_meth_signature.py | 2 | ||||
-rw-r--r-- | pylint/test/input/func_r0922.py | 21 | ||||
-rw-r--r-- | pylint/test/messages/func_r0922.txt | 1 | ||||
-rw-r--r-- | pylintrc | 2 |
11 files changed, 9 insertions, 39 deletions
diff --git a/pylint/checkers/design_analysis.py b/pylint/checkers/design_analysis.py index e361cca..fe5e973 100644 --- a/pylint/checkers/design_analysis.py +++ b/pylint/checkers/design_analysis.py @@ -79,10 +79,6 @@ MSGS = { 'R0921': ('Abstract class not referenced', 'abstract-class-not-used', 'Used when an abstract class is not used as ancestor anywhere.'), - 'R0922': ('Abstract class is only referenced %s times', - 'abstract-class-little-used', - 'Used when an abstract class is used less than X times as \ - ancestor.'), 'R0923': ('Interface not implemented', 'interface-not-implemented', 'Used when an interface class is not implemented anywhere.'), @@ -181,22 +177,18 @@ class MisdesignChecker(BaseChecker): self._abstracts = [] self._ifaces = [] - # Check 'R0921', 'R0922', 'R0923' def close(self): """check that abstract/interface classes are used""" for abstract in self._abstracts: if not abstract in self._used_abstracts: self.add_message('abstract-class-not-used', node=abstract) - elif self._used_abstracts[abstract] < 2: - self.add_message('abstract-class-little-used', node=abstract, - args=self._used_abstracts[abstract]) for iface in self._ifaces: if not iface in self._used_ifaces: self.add_message('interface-not-implemented', node=iface) @check_messages('too-many-ancestors', 'too-many-instance-attributes', 'too-few-public-methods', 'too-many-public-methods', - 'abstract-class-not-used', 'abstract-class-little-used', + 'abstract-class-not-used', 'interface-not-implemented') def visit_class(self, node): """check size of inheritance hierarchy and number of instance attributes diff --git a/pylint/test/functional/abstract_abc_methods.py b/pylint/test/functional/abstract_abc_methods.py index 6a21d90..31ac2ae 100644 --- a/pylint/test/functional/abstract_abc_methods.py +++ b/pylint/test/functional/abstract_abc_methods.py @@ -1,5 +1,5 @@ """ This should not warn about `prop` being abstract in Child """
-# pylint: disable=too-few-public-methods,abstract-class-little-used,no-absolute-import,metaclass-assignment
+# pylint: disable=too-few-public-methods, no-absolute-import,metaclass-assignment
import abc
diff --git a/pylint/test/functional/abstract_class_instantiated_py2.py b/pylint/test/functional/abstract_class_instantiated_py2.py index 670abd4..2fc575a 100644 --- a/pylint/test/functional/abstract_class_instantiated_py2.py +++ b/pylint/test/functional/abstract_class_instantiated_py2.py @@ -4,7 +4,7 @@ abstract methods. """ # pylint: disable=too-few-public-methods, missing-docstring, abstract-class-not-used -# pylint: disable=no-absolute-import, metaclass-assignment, abstract-class-little-used +# pylint: disable=no-absolute-import, metaclass-assignment # pylint: disable=abstract-method __revision__ = 0 diff --git a/pylint/test/functional/abstract_class_instantiated_py3.py b/pylint/test/functional/abstract_class_instantiated_py3.py index 8d94733..561c605 100644 --- a/pylint/test/functional/abstract_class_instantiated_py3.py +++ b/pylint/test/functional/abstract_class_instantiated_py3.py @@ -4,7 +4,7 @@ abstract methods. """ # pylint: disable=too-few-public-methods, missing-docstring -# pylint: disable=abstract-class-not-used, abstract-class-little-used +# pylint: disable=abstract-class-not-used # pylint: disable=abstract-method __revision__ = 0 diff --git a/pylint/test/functional/abstract_method_py2.py b/pylint/test/functional/abstract_method_py2.py index d71faba..341f5de 100644 --- a/pylint/test/functional/abstract_method_py2.py +++ b/pylint/test/functional/abstract_method_py2.py @@ -3,7 +3,7 @@ from __future__ import print_function # pylint: disable=missing-docstring, no-init, no-self-use # pylint: disable=too-few-public-methods -# pylint: disable=abstract-class-little-used, abstract-class-not-used +# pylint: disable=abstract-class-not-used import abc class Abstract(object): diff --git a/pylint/test/functional/abstract_method_py3.py b/pylint/test/functional/abstract_method_py3.py index 308a6e5..93e2cf1 100644 --- a/pylint/test/functional/abstract_method_py3.py +++ b/pylint/test/functional/abstract_method_py3.py @@ -3,7 +3,7 @@ from __future__ import print_function # pylint: disable=missing-docstring, no-init, no-self-use # pylint: disable=too-few-public-methods -# pylint: disable=abstract-class-little-used, abstract-class-not-used +# pylint: disable=abstract-class-not-used import abc class Abstract(object): diff --git a/pylint/test/input/func_method_could_be_function.py b/pylint/test/input/func_method_could_be_function.py index 7544793..92a85bc 100644 --- a/pylint/test/input/func_method_could_be_function.py +++ b/pylint/test/input/func_method_could_be_function.py @@ -1,4 +1,4 @@ -# pylint: disable=R0903,R0922,W0232,print-statement +# pylint: disable=R0903,W0232,print-statement """test detection of method which could be a function""" __revision__ = None diff --git a/pylint/test/input/func_noerror_classes_meth_signature.py b/pylint/test/input/func_noerror_classes_meth_signature.py index 2aa5b18..8a0ad3f 100644 --- a/pylint/test/input/func_noerror_classes_meth_signature.py +++ b/pylint/test/input/func_noerror_classes_meth_signature.py @@ -1,4 +1,4 @@ -# pylint: disable=C0111,R0922,R0903,W0231 +# pylint: disable=C0111,R0903,W0231 """#2485: W0222 "Signature differs from overriden method" false positive #18772: diff --git a/pylint/test/input/func_r0922.py b/pylint/test/input/func_r0922.py deleted file mode 100644 index 705ef3a..0000000 --- a/pylint/test/input/func_r0922.py +++ /dev/null @@ -1,21 +0,0 @@ -"""test max methods""" -__revision__ = None -# pylint: disable=too-few-public-methods -class Aaaa(object): - """yo""" - def __init__(self): - pass - - def meth1(self): - """hehehe""" - raise NotImplementedError - - def meth2(self): - """hehehe""" - return 'Yo', self - -class Bbbb(Aaaa): - """yeah""" - def meth1(self): - """hehehe bis""" - return "yeah", self diff --git a/pylint/test/messages/func_r0922.txt b/pylint/test/messages/func_r0922.txt deleted file mode 100644 index 70319ee..0000000 --- a/pylint/test/messages/func_r0922.txt +++ /dev/null @@ -1 +0,0 @@ -R: 4:Aaaa: Abstract class is only referenced 1 times @@ -60,7 +60,7 @@ confidence= # --enable=similarities". If you want to run only the classes checker, but have # no Warning level messages displayed, use"--disable=all --enable=classes # --disable=W" -disable=C0103,C0111,C0302,C0330,C0401,C0402,C0403,C1001,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0109,E0110,E0111,E0202,E0203,E0211,E0213,E0221,E0222,E0235,E0236,E0237,E0238,E0239,E0601,E0602,E0603,E0604,E0611,E0701,E0702,E0710,E0711,E0712,E1001,E1002,E1003,E1004,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1126,E1127,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1601,E1602,E1603,E1604,E1605,E1606,E1607,E1608,F0001,F0002,F0003,F0010,F0202,F0220,F0401,I0001,I0010,I0011,I0012,I0013,I0020,I0021,I0022,R0201,R0401,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,R0923,W0101,W0102,W0104,W0105,W0106,W0107,W0108,W0109,W0110,W0120,W0122,W0123,W0141,W0142,W0150,W0199,W0201,W0211,W0212,W0221,W0222,W0223,W0231,W0232,W0233,W0234,W0301,W0311,W0312,W0332,W0401,W0402,W0403,W0404,W0406,W0410,W0511,W0512,W0601,W0602,W0603,W0604,W0611,W0612,W0613,W0614,W0621,W0622,W0623,W0631,W0632,W0633,W0640,W0702,W0703,W0704,W0710,W0711,W1001,W1111,W1201,W1202,W1300,W1301,W1302,W1303,W1304,W1305,W1306,W1307,W1401,W1402,W1501,W1502,W1503,W1504,W1601,W1602,W1603,W1604,W1605,W1606,W1607,W1608,W1609,W1610,W1611,W1612,W1613,W1614,W1615,W1616,W1617,W1618,W1619,W1620,W1621,W1622,W1623,W1624,W1625,W1626,W1627,W1628,W1629,W1630,W1632,W1633,W1634,W1635,W1636,W1637,W1638,W1639 +disable=C0103,C0111,C0302,C0330,C0401,C0402,C0403,C1001,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0109,E0110,E0111,E0202,E0203,E0211,E0213,E0221,E0222,E0235,E0236,E0237,E0238,E0239,E0601,E0602,E0603,E0604,E0611,E0701,E0702,E0710,E0711,E0712,E1001,E1002,E1003,E1004,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1126,E1127,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1601,E1602,E1603,E1604,E1605,E1606,E1607,E1608,F0001,F0002,F0003,F0010,F0202,F0220,F0401,I0001,I0010,I0011,I0012,I0013,I0020,I0021,I0022,R0201,R0401,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0923,W0101,W0102,W0104,W0105,W0106,W0107,W0108,W0109,W0110,W0120,W0122,W0123,W0141,W0142,W0150,W0199,W0201,W0211,W0212,W0221,W0222,W0223,W0231,W0232,W0233,W0234,W0301,W0311,W0312,W0332,W0401,W0402,W0403,W0404,W0406,W0410,W0511,W0512,W0601,W0602,W0603,W0604,W0611,W0612,W0613,W0614,W0621,W0622,W0623,W0631,W0632,W0633,W0640,W0702,W0703,W0704,W0710,W0711,W1001,W1111,W1201,W1202,W1300,W1301,W1302,W1303,W1304,W1305,W1306,W1307,W1401,W1402,W1501,W1502,W1503,W1504,W1601,W1602,W1603,W1604,W1605,W1606,W1607,W1608,W1609,W1610,W1611,W1612,W1613,W1614,W1615,W1616,W1617,W1618,W1619,W1620,W1621,W1622,W1623,W1624,W1625,W1626,W1627,W1628,W1629,W1630,W1632,W1633,W1634,W1635,W1636,W1637,W1638,W1639 [REPORTS] |