check missing space between keyword and parenthesis

2 files changed, 11 insertions, 4 deletions

diff --git a/psutil/arch/windows/net.c b/psutil/arch/windows/net.c
index f0572d52..56c6b6f1 100644
--- a/psutil/arch/windows/net.c
+++ b/psutil/arch/windows/net.c
@@ -401,7 +401,7 @@ psutil_net_if_stats(PyObject *self, PyObject *args) {
         }
 
         // is up?
-        if((pIfRow->dwOperStatus == MIB_IF_OPER_STATUS_CONNECTED ||
+        if ((pIfRow->dwOperStatus == MIB_IF_OPER_STATUS_CONNECTED ||
                 pIfRow->dwOperStatus == MIB_IF_OPER_STATUS_OPERATIONAL) &&
                 pIfRow->dwAdminStatus == 1 ) {
             py_is_up = Py_True;
diff --git a/scripts/internal/clinter.py b/scripts/internal/clinter.py
index 695729b7..6e880589 100755
--- a/scripts/internal/clinter.py
+++ b/scripts/internal/clinter.py
@@ -39,10 +39,17 @@ def check_line(path, line, idx, lines):
                     nextline.strip()[0] != '#' and \
                     nextline.strip()[:2] != '*/':
                 warn(path, line, lineno, "expected 1 blank line")
-    # minus initial white spaces
-    s = s.lstrip()
-    if s.startswith('//') and s[2] != ' ' and line.strip() != '//':
+
+    sls = s.lstrip()
+    if sls.startswith('//') and sls[2] != ' ' and line.strip() != '//':
         warn(path, line, lineno, "no space after // comment")
+
+    # e.g. "if(..." after keywords
+    keywords = ("if", "else", "while", "do", "enum", "for")
+    for kw in keywords:
+        if sls.startswith(kw + '('):
+            warn(path, line, lineno, "missing space between %r and '('" % kw)
+    # eof
     if eof:
         if not line.endswith('\n'):
             warn(path, line, lineno, "no blank line at EOF")