summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Wieser <wieser.eric@gmail.com>2020-09-28 16:36:24 +0100
committerGitHub <noreply@github.com>2020-09-28 16:36:24 +0100
commit5e2d8f47703c783e168bd845b65a92b9c8040a0f (patch)
tree9e690e5c173d08c80080dda3b2fb3465ed2cef7f
parentcdd5becba9a39d054f0ae34a493dd16d613f8cb9 (diff)
downloadnumpy-5e2d8f47703c783e168bd845b65a92b9c8040a0f.tar.gz
Apply suggestions from code review
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
-rw-r--r--numpy/core/src/multiarray/datetime_busdaycal.c2
-rw-r--r--numpy/core/src/multiarray/datetime_strings.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/numpy/core/src/multiarray/datetime_busdaycal.c b/numpy/core/src/multiarray/datetime_busdaycal.c
index cec7135ff..d48141d4c 100644
--- a/numpy/core/src/multiarray/datetime_busdaycal.c
+++ b/numpy/core/src/multiarray/datetime_busdaycal.c
@@ -73,7 +73,7 @@ PyArray_WeekMaskConverter(PyObject *weekmask_in, npy_bool *weekmask)
general_weekmask_string:
/* a string like "SatSun" or "Mon Tue Wed" */
memset(weekmask, 0, 7);
- for (int i = 0; i < len; i += 3) {
+ for (Py_ssize_t i = 0; i < len; i += 3) {
while (isspace(str[i]))
++i;
diff --git a/numpy/core/src/multiarray/datetime_strings.c b/numpy/core/src/multiarray/datetime_strings.c
index 8665d3295..360868568 100644
--- a/numpy/core/src/multiarray/datetime_strings.c
+++ b/numpy/core/src/multiarray/datetime_strings.c
@@ -1399,7 +1399,7 @@ array_datetime_as_string(PyObject *NPY_UNUSED(self), PyObject *args,
strobj = unit_in;
}
- Py_ssize_t len = 0;
+ Py_ssize_t len;
char const *str = PyUnicode_AsUTF8AndSize(strobj, &len);
if (str == NULL) {
Py_DECREF(strobj);