STY: flake8 fixes

1 files changed, 96 insertions, 51 deletions

diff --git a/tools/openblas_support.py b/tools/openblas_support.py
index e5e666c76..e370c87f8 100644
--- a/tools/openblas_support.py
+++ b/tools/openblas_support.py
@@ -14,49 +14,82 @@ from urllib.error import HTTPError
 
 OPENBLAS_V = '0.3.10'
 # Temporary build of OpenBLAS to test a fix for dynamic detection of CPU
-OPENBLAS_LONG = 'v0.3.10'  
+OPENBLAS_LONG = 'v0.3.10'
 BASE_LOC = 'https://anaconda.org/multibuild-wheels-staging/openblas-libs'
 BASEURL = f'{BASE_LOC}/{OPENBLAS_LONG}/download'
-ARCHITECTURES = ['', 'windows', 'darwin', 'aarch64', 'x86_64', 'i686', 'ppc64le', 's390x']
+ARCHITECTURES = ['', 'windows', 'darwin', 'aarch64', 'x86_64',
+                 'i686', 'ppc64le', 's390x']
 sha256_vals = {
-"openblas-v0.3.7-527-g79fd006c-win_amd64-gcc_7_1_0.zip": "7249d68c02e6b6339e06edfeab1fecddf29ee1e67a3afaa77917c320c43de840",
-"openblas64_-v0.3.7-527-g79fd006c-win_amd64-gcc_7_1_0.zip": "6488e0961a5926e47242f63b63b41cfdd661e6f1d267e8e313e397cde4775c17",
-"openblas-v0.3.7-527-g79fd006c-win32-gcc_7_1_0.zip": "5fb0867ca70b1d0fdbf68dd387c0211f26903d74631420e4aabb49e94aa3930d",
-"openblas-v0.3.7-527-g79fd006c-macosx_10_9_x86_64-gf_1becaaa.tar.gz": "69434bd626bbc495da9ce8c36b005d140c75e3c47f94e88c764a199e820f9259",
-"openblas64_-v0.3.7-527-g79fd006c-macosx_10_9_x86_64-gf_1becaaa.tar.gz": "093f6d953e3fa76a86809be67bd1f0b27656671b5a55b233169cfaa43fd63e22",
-"openblas-v0.3.7-527-g79fd006c-manylinux2014_aarch64.tar.gz": "42676c69dc48cd6e412251b39da6b955a5a0e00323ddd77f9137f7c259d35319",
-"openblas64_-v0.3.7-527-g79fd006c-manylinux2014_aarch64.tar.gz": "5aec167af4052cf5e9e3e416c522d9794efabf03a2aea78b9bb3adc94f0b73d8",
-"openblas-v0.3.7-527-g79fd006c-manylinux2010_x86_64.tar.gz": "fa67c6cc29d4cc5c70a147c80526243239a6f95fc3feadcf83a78176cd9c526b",
-"openblas64_-v0.3.7-527-g79fd006c-manylinux2010_x86_64.tar.gz": "9ad34e89a5307dcf5823bf5c020580d0559a0c155fe85b44fc219752e61852b0",
-"openblas-v0.3.7-527-g79fd006c-manylinux2010_i686.tar.gz": "0b8595d316c8b7be84ab1f1d5a0c89c1b35f7c987cdaf61d441bcba7ab4c7439",
-"openblas-v0.3.7-527-g79fd006c-manylinux2014_ppc64le.tar.gz": "3e1c7d6472c34e7210e3605be4bac9ddd32f613d44297dc50cf2d067e720c4a9",
-"openblas64_-v0.3.7-527-g79fd006c-manylinux2014_ppc64le.tar.gz": "a0885873298e21297a04be6cb7355a585df4fa4873e436b4c16c0a18fc9073ea",
-"openblas-v0.3.7-527-g79fd006c-manylinux2014_s390x.tar.gz": "79b454320817574e20499d58f05259ed35213bea0158953992b910607b17f240",
-"openblas64_-v0.3.7-527-g79fd006c-manylinux2014_s390x.tar.gz": "9fddbebf5301518fc4a5d2022a61886544a0566868c8c014359a1ee6b17f2814",
-"openblas-v0.3.7-527-g79fd006c-manylinux1_i686.tar.gz": "24fb92684ec4676185fff5c9340f50c3db6075948bcef760e9c715a8974e4680",
-"openblas-v0.3.7-527-g79fd006c-manylinux1_x86_64.tar.gz": "ebb8236b57a1b4075fd5cdc3e9246d2900c133a42482e5e714d1e67af5d00e62",
-"openblas-v0.3.10-win_amd64-gcc_7_1_0.zip": "2ffd656ed441070df2f7a7acb9e610c940701f7e560cc3fb827f4fa4750eeb37",
-"openblas-v0.3.10-win32-gcc_7_1_0.zip": "e9212c5fc9d8620a1d091c2dc90d6f8b1a7943f636b2c482440d9b6f5be49ae4",
-"openblas-v0.3.10-macosx_10_9_x86_64-gf_1becaaa.tar.gz": "c6940b5133e687ae7a4f9c7c794f6a6d92b619cf41e591e5db07aab5da118199",
-"openblas-v0.3.10-manylinux2014_aarch64.tar.gz": "c9bf6cb7cd6bafc1252fc40ca368112caef902536a31660346308714f4ab7504",
-"openblas-v0.3.10-manylinux2010_x86_64.tar.gz": "5e471d171078618b718489ef7e6af1e250ceb5c50d9f9c9ba3cb2d018004fa45",
-"openblas-v0.3.10-manylinux2010_i686.tar.gz": "39626cb4d42b2e6187167712c58a748f13e3bd1eaae00aa48d8d1797c07a85c0",
-"openblas-v0.3.10-manylinux1_x86_64.tar.gz": "57accc9125eea164e3e28c2945db1d8723ef533020aa1d1c8ff0fe4c281fe10b",
-"openblas-v0.3.10-manylinux1_i686.tar.gz": "58645fa0b41819b0e0fbb86fd5ee8469f87da5db9a264c6d9f66887b7878ba31",
-"openblas-v0.3.10-manylinux2014_ppc64le.tar.gz": "ef1a4f27b37a7fcd15bbe0457ceb395b726753c6b43884fce9ad52d18b8b4d27",
-"openblas-v0.3.10-manylinux2014_s390x.tar.gz": "498198057b0b479aa809916d6882f896925957ec399f469e4520d009bbfc258d",
-"openblas64_-v0.3.10-macosx_10_9_x86_64-gf_1becaaa.tar.gz": "91189592d0d801807843863a7249bf4f61621a2d056680d83723f8bb4019242b",
-"openblas64_-v0.3.10-manylinux2014_s390x.tar.gz": "e0347dd6f3f3a27d2f5e76d382e8a4a68e2e92f5f6a10e54ef65c7b14b44d0e8",
-"openblas64_-v0.3.10-manylinux2014_ppc64le.tar.gz": "999e336c81800c7e5ff22628fc1fe3963be6e64f89744f98589b649f4c9a5199",
-"openblas64_-v0.3.10-manylinux2010_x86_64.tar.gz": "2291851d113b8310aae722149ea3dbda3dfe31fc08ec3698fad91923ffdd1b05",
-"openblas64_-v0.3.10-manylinux2014_aarch64.tar.gz": "da9ce72d8c920c633446864469f440dee347b53f7b72437148cfb0aa54b00a18",
-"openblas64_-v0.3.10-win_amd64-gcc_7_1_0.zip": "662f1578d685a9a21da53230e9077c001205100eaa14ea56533c61dfbd0fe14b",
+    "openblas-v0.3.7-527-g79fd006c-win_amd64-gcc_7_1_0.zip":
+    "7249d68c02e6b6339e06edfeab1fecddf29ee1e67a3afaa77917c320c43de840",
+    "openblas64_-v0.3.7-527-g79fd006c-win_amd64-gcc_7_1_0.zip":
+    "6488e0961a5926e47242f63b63b41cfdd661e6f1d267e8e313e397cde4775c17",
+    "openblas-v0.3.7-527-g79fd006c-win32-gcc_7_1_0.zip":
+    "5fb0867ca70b1d0fdbf68dd387c0211f26903d74631420e4aabb49e94aa3930d",
+    "openblas-v0.3.7-527-g79fd006c-macosx_10_9_x86_64-gf_1becaaa.tar.gz":
+    "69434bd626bbc495da9ce8c36b005d140c75e3c47f94e88c764a199e820f9259",
+    "openblas64_-v0.3.7-527-g79fd006c-macosx_10_9_x86_64-gf_1becaaa.tar.gz":
+    "093f6d953e3fa76a86809be67bd1f0b27656671b5a55b233169cfaa43fd63e22",
+    "openblas-v0.3.7-527-g79fd006c-manylinux2014_aarch64.tar.gz":
+    "42676c69dc48cd6e412251b39da6b955a5a0e00323ddd77f9137f7c259d35319",
+    "openblas64_-v0.3.7-527-g79fd006c-manylinux2014_aarch64.tar.gz":
+    "5aec167af4052cf5e9e3e416c522d9794efabf03a2aea78b9bb3adc94f0b73d8",
+    "openblas-v0.3.7-527-g79fd006c-manylinux2010_x86_64.tar.gz":
+    "fa67c6cc29d4cc5c70a147c80526243239a6f95fc3feadcf83a78176cd9c526b",
+    "openblas64_-v0.3.7-527-g79fd006c-manylinux2010_x86_64.tar.gz":
+    "9ad34e89a5307dcf5823bf5c020580d0559a0c155fe85b44fc219752e61852b0",
+    "openblas-v0.3.7-527-g79fd006c-manylinux2010_i686.tar.gz":
+    "0b8595d316c8b7be84ab1f1d5a0c89c1b35f7c987cdaf61d441bcba7ab4c7439",
+    "openblas-v0.3.7-527-g79fd006c-manylinux2014_ppc64le.tar.gz":
+    "3e1c7d6472c34e7210e3605be4bac9ddd32f613d44297dc50cf2d067e720c4a9",
+    "openblas64_-v0.3.7-527-g79fd006c-manylinux2014_ppc64le.tar.gz":
+    "a0885873298e21297a04be6cb7355a585df4fa4873e436b4c16c0a18fc9073ea",
+    "openblas-v0.3.7-527-g79fd006c-manylinux2014_s390x.tar.gz":
+    "79b454320817574e20499d58f05259ed35213bea0158953992b910607b17f240",
+    "openblas64_-v0.3.7-527-g79fd006c-manylinux2014_s390x.tar.gz":
+    "9fddbebf5301518fc4a5d2022a61886544a0566868c8c014359a1ee6b17f2814",
+    "openblas-v0.3.7-527-g79fd006c-manylinux1_i686.tar.gz":
+    "24fb92684ec4676185fff5c9340f50c3db6075948bcef760e9c715a8974e4680",
+    "openblas-v0.3.7-527-g79fd006c-manylinux1_x86_64.tar.gz":
+    "ebb8236b57a1b4075fd5cdc3e9246d2900c133a42482e5e714d1e67af5d00e62",
+    "openblas-v0.3.10-win_amd64-gcc_7_1_0.zip":
+    "2ffd656ed441070df2f7a7acb9e610c940701f7e560cc3fb827f4fa4750eeb37",
+    "openblas-v0.3.10-win32-gcc_7_1_0.zip":
+    "e9212c5fc9d8620a1d091c2dc90d6f8b1a7943f636b2c482440d9b6f5be49ae4",
+    "openblas-v0.3.10-macosx_10_9_x86_64-gf_1becaaa.tar.gz":
+    "c6940b5133e687ae7a4f9c7c794f6a6d92b619cf41e591e5db07aab5da118199",
+    "openblas-v0.3.10-manylinux2014_aarch64.tar.gz":
+    "c9bf6cb7cd6bafc1252fc40ca368112caef902536a31660346308714f4ab7504",
+    "openblas-v0.3.10-manylinux2010_x86_64.tar.gz":
+    "5e471d171078618b718489ef7e6af1e250ceb5c50d9f9c9ba3cb2d018004fa45",
+    "openblas-v0.3.10-manylinux2010_i686.tar.gz":
+    "39626cb4d42b2e6187167712c58a748f13e3bd1eaae00aa48d8d1797c07a85c0",
+    "openblas-v0.3.10-manylinux1_x86_64.tar.gz":
+    "57accc9125eea164e3e28c2945db1d8723ef533020aa1d1c8ff0fe4c281fe10b",
+    "openblas-v0.3.10-manylinux1_i686.tar.gz":
+    "58645fa0b41819b0e0fbb86fd5ee8469f87da5db9a264c6d9f66887b7878ba31",
+    "openblas-v0.3.10-manylinux2014_ppc64le.tar.gz":
+    "ef1a4f27b37a7fcd15bbe0457ceb395b726753c6b43884fce9ad52d18b8b4d27",
+    "openblas-v0.3.10-manylinux2014_s390x.tar.gz":
+    "498198057b0b479aa809916d6882f896925957ec399f469e4520d009bbfc258d",
+    "openblas64_-v0.3.10-macosx_10_9_x86_64-gf_1becaaa.tar.gz":
+    "91189592d0d801807843863a7249bf4f61621a2d056680d83723f8bb4019242b",
+    "openblas64_-v0.3.10-manylinux2014_s390x.tar.gz":
+    "e0347dd6f3f3a27d2f5e76d382e8a4a68e2e92f5f6a10e54ef65c7b14b44d0e8",
+    "openblas64_-v0.3.10-manylinux2014_ppc64le.tar.gz":
+    "999e336c81800c7e5ff22628fc1fe3963be6e64f89744f98589b649f4c9a5199",
+    "openblas64_-v0.3.10-manylinux2010_x86_64.tar.gz":
+    "2291851d113b8310aae722149ea3dbda3dfe31fc08ec3698fad91923ffdd1b05",
+    "openblas64_-v0.3.10-manylinux2014_aarch64.tar.gz":
+    "da9ce72d8c920c633446864469f440dee347b53f7b72437148cfb0aa54b00a18",
+    "openblas64_-v0.3.10-win_amd64-gcc_7_1_0.zip":
+    "662f1578d685a9a21da53230e9077c001205100eaa14ea56533c61dfbd0fe14b",
 }
 
 
-
 IS_32BIT = sys.maxsize < 2**32
 
+
 def get_arch():
     if platform.system() == 'Windows':
         ret = 'windows'
@@ -67,10 +100,11 @@ def get_arch():
         # What do 32 bit machines report?
         # If they are a docker, they can report x86_64
         if 'x86' in ret and IS_32BIT:
-            arch = 'i686'
+            ret = 'i686'
     assert ret in ARCHITECTURES, f'invalid architecture {ret}'
     return ret
 
+
 def get_ilp64():
     if os.environ.get("NPY_USE_BLAS_ILP64", "0") == "0":
         return None
@@ -78,6 +112,7 @@ def get_ilp64():
         raise RuntimeError("NPY_USE_BLAS_ILP64 set on 32-bit arch")
     return "64_"
 
+
 def get_manylinux(arch):
     if arch in ('x86_64', 'i686'):
         default = '2010'
@@ -93,9 +128,9 @@ def download_openblas(target, arch, ilp64, is_32bit):
     ml_ver = get_manylinux(arch)
     fnsuffix = {None: "", "64_": "64_"}[ilp64]
     filename = ''
-    headers = {'User-Agent': ('Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 ; '
-                              '(KHTML, like Gecko) Chrome/41.0.2228.0 '
-                              'Safari/537.3')}
+    headers = {'User-Agent':
+               ('Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 ; '
+                '(KHTML, like Gecko) Chrome/41.0.2228.0 Safari/537.3')}
     if arch in ('aarch64', 'ppc64le', 's390x', 'x86_64', 'i686'):
         suffix = f'manylinux{ml_ver}_{arch}.tar.gz'
         filename = f'{BASEURL}/openblas{fnsuffix}-{OPENBLAS_LONG}-{suffix}'
@@ -116,7 +151,7 @@ def download_openblas(target, arch, ilp64, is_32bit):
     req = Request(url=filename, headers=headers)
     try:
         response = urlopen(req)
-    except HTTPError as e:
+    except HTTPError:
         print(f'Could not download "{filename}"', file=sys.stderr)
         raise
     length = response.getheader('content-length')
@@ -139,6 +174,7 @@ def download_openblas(target, arch, ilp64, is_32bit):
         fid.write(data)
     return typ
 
+
 def setup_openblas(arch=get_arch(), ilp64=get_ilp64(), is_32bit=IS_32BIT):
     '''
     Download and setup an openblas library for building. If successful,
@@ -158,19 +194,20 @@ def setup_openblas(arch=get_arch(), ilp64=get_ilp64(), is_32bit=IS_32BIT):
         return ''
     if arch == 'windows':
         if not typ == 'zip':
-            return 'expecting to download zipfile on windows, not %s' % str(typ)
+            return f'expecting to download zipfile on windows, not {typ}'
         return unpack_windows_zip(tmp)
     else:
         if not typ == 'tar.gz':
             return 'expecting to download tar.gz, not %s' % str(typ)
         return unpack_targz(tmp)
 
+
 def unpack_windows_zip(fname):
     with zipfile.ZipFile(fname, 'r') as zf:
         # Get the openblas.a file, but not openblas.dll.a nor openblas.dev.a
         lib = [x for x in zf.namelist() if OPENBLAS_LONG in x and
-                  x.endswith('a') and not x.endswith('dll.a') and
-                  not x.endswith('dev.a')]
+               x.endswith('a') and not x.endswith('dll.a') and
+               not x.endswith('dev.a')]
         if not lib:
             return 'could not find libopenblas_%s*.a ' \
                     'in downloaded zipfile' % OPENBLAS_LONG
@@ -179,6 +216,7 @@ def unpack_windows_zip(fname):
             fid.write(zf.read(lib[0]))
     return target
 
+
 def unpack_targz(fname):
     target = os.path.join(gettempdir(), 'openblas')
     if not os.path.exists(target):
@@ -189,6 +227,7 @@ def unpack_targz(fname):
         extract_tarfile_to(zf, target, prefix)
         return target
 
+
 def extract_tarfile_to(tarfileobj, target_path, archive_path):
     """Extract TarFile contents under archive_path/ to target_path/"""
 
@@ -212,6 +251,7 @@ def extract_tarfile_to(tarfileobj, target_path, archive_path):
 
     tarfileobj.extractall(target_path, members=get_members())
 
+
 def make_init(dirname):
     '''
     Create a _distributor_init.py file for OpenBlas
@@ -246,11 +286,12 @@ def make_init(dirname):
                             DLL_filenames.append(filename)
                     if len(DLL_filenames) > 1:
                         import warnings
-                        warnings.warn("loaded more than 1 DLL from .libs:\\n%s" %
-                                      "\\n".join(DLL_filenames),
+                        warnings.warn("loaded more than 1 DLL from .libs:"
+                                      "\\n%s" % "\\n".join(DLL_filenames),
                                       stacklevel=1)
     """))
 
+
 def test_setup(arches):
     '''
     Make sure all the downloadable files exist and can be opened
@@ -286,7 +327,8 @@ def test_setup(arches):
             try:
                 target = setup_openblas(arch, ilp64, is_32bit)
             except Exception as e:
-                print(f'Could not setup {arch} with ilp64 {ilp64}, 32bit {is_32bit}:')
+                print(f'Could not setup {arch} with ilp64 {ilp64}, '
+                      f'32bit {is_32bit}:')
                 print(e)
                 errs.append(e)
                 continue
@@ -323,28 +365,31 @@ def test_version(expected_version, ilp64=get_ilp64()):
         get_config = dll.openblas_get_config64_
     else:
         get_config = dll.openblas_get_config
-    get_config.restype=ctypes.c_char_p
+    get_config.restype = ctypes.c_char_p
     res = get_config()
     print('OpenBLAS get_config returned', str(res))
     if not expected_version:
         expected_version = OPENBLAS_V
     check_str = b'OpenBLAS %s' % expected_version.encode()
     print(check_str)
-    assert check_str in res, '%s not found in %s' %(expected_version, res)
+    assert check_str in res, f'{expected_version} not found in {res}'
     if ilp64:
         assert b"USE64BITINT" in res
     else:
         assert b"USE64BITINT" not in res
 
+
 if __name__ == '__main__':
     import argparse
     parser = argparse.ArgumentParser(
-        description='Download and expand an OpenBLAS archive for this ' \
+        description='Download and expand an OpenBLAS archive for this '
                     'architecture')
     parser.add_argument('--test', nargs='*', default=None,
-        help='Test different architectures. "all", or any of %s' % ARCHITECTURES)
+                        help='Test different architectures. "all", or any of '
+                             f'{ARCHITECTURES}')
     parser.add_argument('--check_version', nargs='?', default='',
-        help='Check provided OpenBLAS version string against available OpenBLAS')
+                        help='Check provided OpenBLAS version string '
+                             'against available OpenBLAS')
     args = parser.parse_args()
     if args.check_version != '':
         test_version(args.check_version)