diff options
| author | Sebastian Berg <sebastian@sipsolutions.net> | 2021-04-16 12:52:55 -0500 |
|---|---|---|
| committer | Sebastian Berg <sebastian@sipsolutions.net> | 2021-04-16 12:52:55 -0500 |
| commit | 853e2334449429860769bf7e19e7d151c7125729 (patch) | |
| tree | dc1341a16e16c90cdb455cba534162833f26a35b | |
| parent | c7282cfa790c47b7c2ec17e56c01623e5f086d67 (diff) | |
| download | numpy-853e2334449429860769bf7e19e7d151c7125729.tar.gz | |
CI: Use `towncrier build` explicitly
Without any argument towncrier defaults to `build`. But towncrier
added a `--version` argument to just print the towncrier version.
NumPy relies on passing `--version` which collides. Even if
towncrier might revert the change, using `towncrier build` explicitly
just doesn't hurt.
Closes gh-18788
| -rw-r--r-- | .circleci/config.yml | 2 | ||||
| -rw-r--r-- | doc/release/upcoming_changes/README.rst | 2 | ||||
| -rwxr-xr-x | tools/ci/test_all_newsfragments_used.py | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/.circleci/config.yml b/.circleci/config.yml index 6f4a32513..ac85d4937 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -42,7 +42,7 @@ jobs: . venv/bin/activate pip install git+https://github.com/hawkowl/towncrier.git@master VERSION=$(python -c "import setup; print(setup.VERSION)") - towncrier --version $VERSION --yes + towncrier build --version $VERSION --yes ./tools/ci/test_all_newsfragments_used.py - run: diff --git a/doc/release/upcoming_changes/README.rst b/doc/release/upcoming_changes/README.rst index ff5ca514c..436535ecd 100644 --- a/doc/release/upcoming_changes/README.rst +++ b/doc/release/upcoming_changes/README.rst @@ -50,7 +50,7 @@ and double-backticks for code. If you are unsure what pull request type to use, don't hesitate to ask in your PR. -You can install ``towncrier`` and run ``towncrier --draft --version 1.18`` +You can install ``towncrier`` and run ``towncrier build --draft --version 1.18`` if you want to get a preview of how your change will look in the final release notes. diff --git a/tools/ci/test_all_newsfragments_used.py b/tools/ci/test_all_newsfragments_used.py index c2e031549..62c9a05f9 100755 --- a/tools/ci/test_all_newsfragments_used.py +++ b/tools/ci/test_all_newsfragments_used.py @@ -12,5 +12,5 @@ fragments.remove("template.rst") if fragments: print("The following files were not found by towncrier:") - print(" " + " \n".join(fragments)) + print(" " + "\n ".join(fragments)) sys.exit(1) |