summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouglas Fenstermacher <douglas.fenstermacher@gmail.com>2020-11-05 10:39:07 -0500
committerGitHub <noreply@github.com>2020-11-05 09:39:07 -0600
commit49d62f84df0a82b10b3623024ca66b1f09958072 (patch)
treeb6b79eb8bb3a0528e52f4c2ae966c97c5838df9b
parent93d3e7c247b66ec54d1095df30e99a95b4af9c72 (diff)
downloadnumpy-49d62f84df0a82b10b3623024ca66b1f09958072.tar.gz
ENH: adds type hints to numpy.version (gh-17711)
Closes gh-17702
-rw-r--r--numpy/typing/tests/test_isfile.py1
-rw-r--r--numpy/version.pyi7
-rwxr-xr-xsetup.py10
3 files changed, 5 insertions, 13 deletions
diff --git a/numpy/typing/tests/test_isfile.py b/numpy/typing/tests/test_isfile.py
index e6b80f995..569f05435 100644
--- a/numpy/typing/tests/test_isfile.py
+++ b/numpy/typing/tests/test_isfile.py
@@ -12,7 +12,6 @@ FILES = [
ROOT / "ctypeslib.pyi",
ROOT / "emath.pyi",
ROOT / "rec.pyi",
- ROOT / "version.pyi",
ROOT / "core" / "__init__.pyi",
ROOT / "distutils" / "__init__.pyi",
ROOT / "f2py" / "__init__.pyi",
diff --git a/numpy/version.pyi b/numpy/version.pyi
deleted file mode 100644
index 6f3659e43..000000000
--- a/numpy/version.pyi
+++ /dev/null
@@ -1,7 +0,0 @@
-from typing import Any
-
-short_version: Any
-version: Any
-full_version: Any
-git_revision: Any
-release: Any
diff --git a/setup.py b/setup.py
index 6d7e90c6a..93db8c8fa 100755
--- a/setup.py
+++ b/setup.py
@@ -140,11 +140,11 @@ def write_version_py(filename='numpy/version.py'):
# THIS FILE IS GENERATED FROM NUMPY SETUP.PY
#
# To compare versions robustly, use `numpy.lib.NumpyVersion`
-short_version = '%(version)s'
-version = '%(version)s'
-full_version = '%(full_version)s'
-git_revision = '%(git_revision)s'
-release = %(isrelease)s
+short_version: str = '%(version)s'
+version: str = '%(version)s'
+full_version: str = '%(full_version)s'
+git_revision: str = '%(git_revision)s'
+release: bool = %(isrelease)s
if not release:
version = full_version